Am 10.06.22 um 17:46 schrieb Alex Deucher:
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1542:11:
warning: variable 'i' set but not used [-Wunused-but-set-variable]

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>

Ideally we should put the code for this into a separate function and then guard the decleration of the function with #ifdefs.

But not code that I'm deeply involved with so Acked-by: Christian König <[email protected]> anyway.

Christian.

---
  drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
index 3e240b22ec91..411447357196 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
@@ -1539,7 +1539,10 @@ static int kfd_dev_create_p2p_links(void)
  {
        struct kfd_topology_device *dev;
        struct kfd_topology_device *new_dev;
-       uint32_t i, k;
+#if defined(CONFIG_HSA_AMD_P2P)
+       uint32_t i;
+#endif
+       uint32_t k;
        int ret = 0;
k = 0;
@@ -1553,7 +1556,6 @@ static int kfd_dev_create_p2p_links(void)
                return 0;
k--;
-       i = 0;
/* create in-direct links */
        ret = kfd_create_indirect_link_prop(new_dev, k);
@@ -1562,6 +1564,7 @@ static int kfd_dev_create_p2p_links(void)
/* create p2p links */
  #if defined(CONFIG_HSA_AMD_P2P)
+       i = 0;
        list_for_each_entry(dev, &topology_device_list, list) {
                if (dev == new_dev)
                        break;

Reply via email to