Re: [PATCH] drm/amd/display: Add a proper DMI match for Precision devices

[Rodrigo Siqueira Jordao]

On 12/07/2022 12:02, Limonciello, Mario wrote:

On 7/12/2022 10:59, Rodrigo Siqueira wrote:

We had an MST fix for some DELL devices that got merged, but we missed
other products. This commit adds the other missing Precision devices.

Cc: Mario Limonciello <mario.limoncie...@amd.com>
Cc: Jerry Zuo <jerry....@amd.com>
Cc: Qian Fu <qian...@dell.com>
Cc: Alex Deucher <alexander.deuc...@amd.com>

Fixes: 9fcd8af669d7 ("drm/amd/display: Ignore First MST Sideband Message Return Error")

Signed-off-by: Rodrigo Siqueira <rodrigo.sique...@amd.com>
---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 ++++++++++++
  1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index e203d75834de..96a0be8508ce 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

@@ -1408,6 +1408,18 @@ static const struct dmi_system_id hpd_disconnect_quirk_table[] = {

              DMI_MATCH(DMI_PRODUCT_NAME, "Precision 3660"),
          },
      },
+    {
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Precision 3260"),
+    },

Just a nit here, the "}," should be indented one tab to the right.

Reviewed-by: Mario Limonciello <mario.limoncie...@amd.com>

I made the requested change and merged it into amd-staging-drm-next.

Thanks
Siqueira

+    },
+    {
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Precision 3460"),
+        },
+    },
      {}
  };