Re: [PATCH] drm/amdgpu: Fix the incomplete product number

[Christian König]

Am 18.07.22 um 14:08 schrieb yehonsun:
The comments say that the product number is a 16-digit HEX string so the
buffer needs to be at least 17 characters to hold the NUL terminator.
The comments say that the product number is a 16-digit HEX string so the
buffer needs to be at least 17 characters to hold the NUL terminator.

Well first of all you repeated the commit message twice.

Then when it is fixed 16 digit Hex string then we probably don't have a 
NUL terminator in the first place.

Please double check.

Regards,
Christian.


Signed-off-by: yehonsun <yehon...@amd.com>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h 
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 9f729a648005..187e3dae3965 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -1019,7 +1019,7 @@ struct amdgpu_device {
        bool                            psp_sysfs_en;
  
  	/* Chip product information */
-       char                            product_number[16];
+       char                            product_number[20];
        char                            product_name[AMDGPU_PRODUCT_NAME_LEN];
        char                            serial[20];