Hi Xiaojian, Please move the power up IPU to "smu->is_apu" as Evan' comment and make sure this is only called for PSP FW load type as backdoor loading already included this in the IMU start process. After this,
Series is Reviewed-by: Tim Huang <[email protected]> Best Regards, Tim Huang -----Original Message----- From: Quan, Evan <[email protected]> Sent: Thursday, July 28, 2022 4:14 PM To: Du, Xiaojian <[email protected]>; [email protected] Cc: Deucher, Alexander <[email protected]>; Huang, Tim <[email protected]>; Du, Xiaojian <[email protected]>; Zhang, Yifan <[email protected]> Subject: RE: [PATCH 1/5] drm/amdgpu: send msg to IMU for the front-door loading [AMD Official Use Only - General] > -----Original Message----- > From: amd-gfx <[email protected]> On Behalf Of > Xiaojian Du > Sent: Thursday, July 28, 2022 3:04 PM > To: [email protected] > Cc: Deucher, Alexander <[email protected]>; Huang, Tim > <[email protected]>; Du, Xiaojian <[email protected]>; Zhang, Yifan > <[email protected]> > Subject: [PATCH 1/5] drm/amdgpu: send msg to IMU for the front-door > loading > > This patch will make SMU send msg to IMU for the front-door loading, > it is required by some ASICs. > > Signed-off-by: Yifan Zhang <[email protected]> > Signed-off-by: Xiaojian Du <[email protected]> > --- > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > index 6d9b3c6af164..79c01fa4b875 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > @@ -1360,6 +1360,14 @@ static int smu_hw_init(void *handle) > return ret; > } > > + if (smu->ppt_funcs->set_gfx_power_up_by_imu) { > + ret = smu->ppt_funcs->set_gfx_power_up_by_imu(smu); > + if (ret) { > + dev_err(adev->dev, "Failed to Enable gfx imu!\n"); > + return ret; > + } > + } [Quan, Evan] Per my understandings, this should be needed by APU only. Can you move this under "smu->is_apu" control as other features below? Evan > + > if (smu->is_apu) { > smu_dpm_set_vcn_enable(smu, true); > smu_dpm_set_jpeg_enable(smu, true); > -- > 2.25.1
