Thanks, it makes sense and will refine the code before push.
Regards, --Prike -----Original Message----- From: Liu, Aaron <[email protected]> Sent: Thursday, August 25, 2022 8:28 AM To: Liang, Prike <[email protected]>; [email protected] Cc: Deucher, Alexander <[email protected]>; Huang, Ray <[email protected]>; Zhang, Yifan <[email protected]>; Limonciello, Mario <[email protected]> Subject: RE: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7 [Public] Because GC_IP_VERSION 10.3.6&10.3.7 all use 1036 ISA version, one nit-pick as below. It looks better. case IP_VERSION(10, 3, 6): case IP_VERSION(10, 3, 7): gfx_target_version = 100306; if (!vf) f2g = &gfx_v10_3_kfd2kgd; break; > -----Original Message----- > From: Liu, Aaron > Sent: Thursday, August 25, 2022 8:15 AM > To: Liang, Prike <[email protected]>; [email protected] > Cc: Deucher, Alexander <[email protected]>; Huang, Ray > <[email protected]>; Zhang, Yifan <[email protected]>; Limonciello, > Mario <[email protected]> > Subject: RE: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7 > > [Public] > > Reviewed-by: Aaron Liu <[email protected]> > > > -----Original Message----- > > From: Liang, Prike <[email protected]> > > Sent: Wednesday, August 24, 2022 8:40 PM > > To: Liang, Prike <[email protected]>; > > [email protected] > > Cc: Deucher, Alexander <[email protected]>; Huang, Ray > > <[email protected]>; Zhang, Yifan <[email protected]>; Liu, > Aaron > > <[email protected]>; Limonciello, Mario <[email protected]> > > Subject: RE: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7 > > > > [Public] > > > > Add more for the review and awareness. > > > > Regards, > > --Prike > > > > -----Original Message----- > > From: Prike Liang <[email protected]> > > Sent: Wednesday, August 24, 2022 2:41 PM > > To: [email protected] > > Cc: Deucher, Alexander <[email protected]>; Huang, Ray > > <[email protected]>; Zhang, Yifan <[email protected]>; Liang, > Prike > > <[email protected]> > > Subject: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7 > > > > Correct the isa version for handling KFD test. > > > > Fixes: 7c4f4f197e0c ("drm/amdkfd: Add GC 10.3.6 and 10.3.7 KFD > > definitions") > > Signed-off-by: Prike Liang <[email protected]> > > --- > > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c > > b/drivers/gpu/drm/amd/amdkfd/kfd_device.c > > index fdad1415f8bd..5ebbeac61379 100644 > > --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c > > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c > > @@ -388,7 +388,7 @@ struct kfd_dev *kgd2kfd_probe(struct > amdgpu_device > > *adev, bool vf) > > f2g = &gfx_v10_3_kfd2kgd; > > break; > > case IP_VERSION(10, 3, 7): > > - gfx_target_version = 100307; > > + gfx_target_version = 100306; > > if (!vf) > > f2g = &gfx_v10_3_kfd2kgd; > > break; > > -- > > 2.25.1 > >
