Am 28.09.22 um 20:22 schrieb Vignesh Chander:
For xgmi sriov, the reset is handled by host driver and hive->reset_domain is not initialized so need to check if it exists before doing a put.
Once more: General practice is to make the *_put_*() functions NULL tolerant.
So rather make this than this patch here. Regards, Christian.
Signed-off-by: Vignesh Chander <vignesh.chan...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c index 47159e9a0884..80fb6ef929e5 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c @@ -217,7 +217,8 @@ static void amdgpu_xgmi_hive_release(struct kobject *kobj) struct amdgpu_hive_info *hive = container_of( kobj, struct amdgpu_hive_info, kobj);- amdgpu_reset_put_reset_domain(hive->reset_domain);+ if (hive->reset_domain) + amdgpu_reset_put_reset_domain(hive->reset_domain); hive->reset_domain = NULL;mutex_destroy(&hive->hive_lock);
