From: "Leo (Hanghong) Ma" <hanghong...@amd.com>

[Why && How]
Remove the unnecessary AUX trace and use one trace for AUX failure.

Reviewed-by: Martin Leung <martin.le...@amd.com>
Acked-by: Hamza Mahfooz <hamza.mahf...@amd.com>
Signed-off-by: Leo (Hanghong) Ma <hanghong...@amd.com>
---
 drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c 
b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
index 32782ef9ef77..140297c8ff55 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
@@ -942,10 +942,6 @@ bool dce_aux_transfer_with_retries(struct ddc_service *ddc,
                case AUX_RET_ERROR_ENGINE_ACQUIRE:
                case AUX_RET_ERROR_UNKNOWN:
                default:
-                       DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_INFORMATION,
-                                               LOG_FLAG_I2cAux_DceAux,
-                                               "dce_aux_transfer_with_retries: 
Failure: operation_result=%d",
-                                               (int)operation_result);
                        goto fail;
                }
        }
@@ -953,14 +949,11 @@ bool dce_aux_transfer_with_retries(struct ddc_service 
*ddc,
 fail:
        DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_ERROR,
                                LOG_FLAG_Error_I2cAux,
-                               "dce_aux_transfer_with_retries: FAILURE");
+                               "%s: Failure: operation_result=%d",
+                               __func__,
+                               (int)operation_result);
        if (!payload_reply)
                payload->reply = NULL;
 
-       DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_ERROR,
-                               WPP_BIT_FLAG_DC_ERROR,
-                               "AUX transaction failed. Result: %d",
-                               operation_result);
-
        return false;
 }
-- 
2.37.2

Reply via email to