[Public] Hi Mario,
-----Original Message----- From: Limonciello, Mario <mario.limoncie...@amd.com> Sent: Saturday, January 21, 2023 12:36 AM To: Huang, Tim <tim.hu...@amd.com>; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Zhang, Yifan <yifan1.zh...@amd.com>; Du, Xiaojian <xiaojian...@amd.com>; Ma, Li <li...@amd.com> Subject: RE: [PATCH 2/2] drm/amd/pm: drop unneeded dpm features disablement for SMU 13.0.4/11 [Public] > -----Original Message----- > From: Huang, Tim <tim.hu...@amd.com> > Sent: Friday, January 20, 2023 10:29 > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Zhang, Yifan > <yifan1.zh...@amd.com>; Du, Xiaojian <xiaojian...@amd.com>; Ma, Li > <li...@amd.com>; Limonciello, Mario <mario.limoncie...@amd.com>; > Huang, Tim <tim.hu...@amd.com> > Subject: [PATCH 2/2] drm/amd/pm: drop unneeded dpm features > disablement for SMU 13.0.4/11 > > PMFW will handle that properly. Driver involvement may cause some > unexpected issues. > > Signed-off-by: Tim Huang <tim.hu...@amd.com> > --- > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > index ec52830dde24..800eb5ad1dcb 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > @@ -1448,6 +1448,8 @@ static int smu_disable_dpms(struct smu_context > *smu) > case IP_VERSION(13, 0, 0): > case IP_VERSION(13, 0, 7): > case IP_VERSION(13, 0, 10): > + case IP_VERSION(13, 0, 4): > To keep a consistent ordering scheme, I think IP_VERSION(13, 0, 4) should > come after IP_VERION(13, 0, 0). Thanks for point out that, but I will drop this patch and send a new one to apply it only for gpu reset case. w/ that fixed: Reviewed-by: Mario Limonciello <mario.limoncie...@amd.com> 6.1 is used for IP_VERSION(13, 0, 4), so please also include Cc: sta...@vger.kernel.org #6.1 > + case IP_VERSION(13, 0, 11): > return 0; > default: > break; > -- > 2.25.1
