Re: [PATCH] drm/amd: Downgrade message about watermarks table after s0i3 to debug

[Alex Deucher]

Acked-by: Alex Deucher <alexander.deuc...@amd.com>

On Fri, Apr 28, 2023 at 5:45 PM Mario Limonciello
<mario.limoncie...@amd.com> wrote:
>
> This message shows up on s0i3 resume for DCN31 and DCN314 platforms but
> it has been decided that this flow won't be changed and the message is
> expected behavior.
>
> Downgrade the message to debug.
>
> Signed-off-by: Mario Limonciello <mario.limoncie...@amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c   | 2 +-
>  drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c 
> b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c
> index 0827c7df28557..32279c5db7248 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c
> @@ -130,7 +130,7 @@ static int dcn31_smu_send_msg_with_param(struct 
> clk_mgr_internal *clk_mgr,
>         if (result == VBIOSSMC_Result_Failed) {
>                 if (msg_id == VBIOSSMC_MSG_TransferTableDram2Smu &&
>                     param == TABLE_WATERMARKS)
> -                       DC_LOG_WARNING("Watermarks table not configured 
> properly by SMU");
> +                       DC_LOG_DEBUG("Watermarks table not configured 
> properly by SMU");
>                 else
>                         ASSERT(0);
>                 REG_WRITE(MP1_SMN_C2PMSG_91, VBIOSSMC_Result_OK);
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c 
> b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> index 0765334f08259..07baa10a86473 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> @@ -145,7 +145,7 @@ static int dcn314_smu_send_msg_with_param(struct 
> clk_mgr_internal *clk_mgr,
>         if (result == VBIOSSMC_Result_Failed) {
>                 if (msg_id == VBIOSSMC_MSG_TransferTableDram2Smu &&
>                     param == TABLE_WATERMARKS)
> -                       DC_LOG_WARNING("Watermarks table not configured 
> properly by SMU");
> +                       DC_LOG_DEBUG("Watermarks table not configured 
> properly by SMU");
>                 else if (msg_id == VBIOSSMC_MSG_SetHardMinDcfclkByFreq ||
>                          msg_id == VBIOSSMC_MSG_SetMinDeepSleepDcfclk)
>                         DC_LOG_WARNING("DCFCLK_DPM is not enabled by BIOS");
> --
> 2.25.1
>