[AMD Official Use Only - General] Reviewed-by: Lijo Lazar <[email protected]>
Thanks, Lijo -----Original Message----- From: SHANMUGAM, SRINIVASAN <[email protected]> Sent: Friday, May 19, 2023 6:53 PM To: Koenig, Christian <[email protected]>; Deucher, Alexander <[email protected]>; Tuikov, Luben <[email protected]>; Lazar, Lijo <[email protected]> Cc: [email protected]; SHANMUGAM, SRINIVASAN <[email protected]> Subject: [PATCH v2] drm/amdgpu: Fix unused amdgpu_acpi_get_numa_info function in amdgpu_acpi_get_node_id() Fix the below compiler complaining error: drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:860:33: error: unused function 'amdgpu_acpi_get_numa_info' [-Werror,-Wunused-function] static struct amdgpu_numa_info *amdgpu_acpi_get_numa_info(uint32_t pxm) ^ 1 error generated. By guarding amdgpu_acpi_get_numa_info & amdgpu_acpi_get_numa_size function, only when CONFIG_ACPI_NUMA is enabled. Suggested-by: Lijo Lazar <[email protected]> Cc: Christian König <[email protected]> Cc: Lijo Lazar <[email protected]> Cc: Luben Tuikov <[email protected]> Cc: Alex Deucher <[email protected]> Signed-off-by: Srinivasan Shanmugam <[email protected]> --- v2: - Guard even amdgpu_acpi_get_numa_size under CONFIG_ACPI_NUMA (Lijo) drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c index 7150c09933cf..1a66febf6981 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c @@ -841,6 +841,7 @@ int amdgpu_acpi_smart_shift_update(struct drm_device *dev, enum amdgpu_ss ss_sta return r; } +#ifdef CONFIG_ACPI_NUMA static inline uint64_t amdgpu_acpi_get_numa_size(int nid) { /* This is directly using si_meminfo_node implementation as the @@ -886,6 +887,7 @@ static struct amdgpu_numa_info *amdgpu_acpi_get_numa_info(uint32_t pxm) return numa_info; } +#endif /** * amdgpu_acpi_get_node_id - obtain the NUMA node id for corresponding amdgpu -- 2.25.1
