Re: [PATCH] drm/amd/display: Drop unused res_create_maximus_funcs & debug_defaults_diags variables

Wed, 24 May 2023 09:30:46 -0700 

On 5/24/23 12:19, Srinivasan Shanmugam wrote:

gcc with W=1
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn321/dcn321_resource.c:1346:43: 
warning: ‘res_create_maximus_funcs’ defined but not used 
[-Wunused-const-variable=]
  1346 | static const struct resource_create_funcs res_create_maximus_funcs = {
       |                                           ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn321/dcn321_resource.c:735:38: 
warning: ‘debug_defaults_diags’ defined but not used [-Wunused-const-variable=]
   735 | static const struct dc_debug_options debug_defaults_diags = {
       |                                      ^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c:1360:43: 
warning: ‘res_create_maximus_funcs’ defined but not used 
[-Wunused-const-variable=]
  1360 | static const struct resource_create_funcs res_create_maximus_funcs = {
       |                                           ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c:737:38: 
warning: ‘debug_defaults_diags’ defined but not used [-Wunused-const-variable=]
   737 | static const struct dc_debug_options debug_defaults_diags = {
       |

These variables are not used so removed them.

Cc: Aurabindo Pillai <[email protected]>
Signed-off-by: Srinivasan Shanmugam <[email protected]>


There is already a series queued that addresses this issue.


---
  .../drm/amd/display/dc/dcn32/dcn32_resource.c | 29 ------------------
  .../amd/display/dc/dcn321/dcn321_resource.c   | 30 -------------------
  2 files changed, 59 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c 
b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c
index 33abc8c9d4be..2e6b39fe2613 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c
@@ -734,26 +734,6 @@ static const struct dc_debug_options debug_defaults_drv = {
        .fpo_vactive_max_blank_us = 1000,
  };
-static const struct dc_debug_options debug_defaults_diags = { 
-       .disable_dmcu = true,
-       .force_abm_enable = false,
-       .timing_trace = true,
-       .clock_trace = true,
-       .disable_dpp_power_gate = true,
-       .disable_hubp_power_gate = true,
-       .disable_dsc_power_gate = true,
-       .disable_clock_gate = true,
-       .disable_pplib_clock_request = true,
-       .disable_pplib_wm_range = true,
-       .disable_stutter = false,
-       .scl_reset_length10 = true,
-       .dwb_fi_phase = -1, // -1 = disable
-       .dmub_command_table = true,
-       .enable_tri_buf = true,
-       .use_max_lb = true,
-       .force_disable_subvp = true
-};
-
  static struct dce_aux *dcn32_aux_engine_create(
        struct dc_context *ctx,
        uint32_t inst)
@@ -1357,15 +1337,6 @@ static const struct resource_create_funcs 
res_create_funcs = {
        .create_hwseq = dcn32_hwseq_create,
  };
-static const struct resource_create_funcs res_create_maximus_funcs = { 
-       .read_dce_straps = NULL,
-       .create_audio = NULL,
-       .create_stream_encoder = NULL,
-       .create_hpo_dp_stream_encoder = dcn32_hpo_dp_stream_encoder_create,
-       .create_hpo_dp_link_encoder = dcn32_hpo_dp_link_encoder_create,
-       .create_hwseq = dcn32_hwseq_create,
-};
-
  static void dcn32_resource_destruct(struct dcn32_resource_pool *pool)
  {
        unsigned int i;
diff --git a/drivers/gpu/drm/amd/display/dc/dcn321/dcn321_resource.c 
b/drivers/gpu/drm/amd/display/dc/dcn321/dcn321_resource.c
index af0bb3e94250..bbcd3579fea6 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn321/dcn321_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn321/dcn321_resource.c
@@ -732,27 +732,6 @@ static const struct dc_debug_options debug_defaults_drv = {
        .fpo_vactive_max_blank_us = 1000,
  };
-static const struct dc_debug_options debug_defaults_diags = { 
-       .disable_dmcu = true,
-       .force_abm_enable = false,
-       .timing_trace = true,
-       .clock_trace = true,
-       .disable_dpp_power_gate = true,
-       .disable_hubp_power_gate = true,
-       .disable_dsc_power_gate = true,
-       .disable_clock_gate = true,
-       .disable_pplib_clock_request = true,
-       .disable_pplib_wm_range = true,
-       .disable_stutter = false,
-       .scl_reset_length10 = true,
-       .dwb_fi_phase = -1, // -1 = disable
-       .dmub_command_table = true,
-       .enable_tri_buf = true,
-       .use_max_lb = true,
-       .force_disable_subvp = true,
-};
-
-
  static struct dce_aux *dcn321_aux_engine_create(
        struct dc_context *ctx,
        uint32_t inst)
@@ -1343,15 +1322,6 @@ static const struct resource_create_funcs 
res_create_funcs = {
        .create_hwseq = dcn321_hwseq_create,
  };
-static const struct resource_create_funcs res_create_maximus_funcs = { 
-       .read_dce_straps = NULL,
-       .create_audio = NULL,
-       .create_stream_encoder = NULL,
-       .create_hpo_dp_stream_encoder = dcn321_hpo_dp_stream_encoder_create,
-       .create_hpo_dp_link_encoder = dcn321_hpo_dp_link_encoder_create,
-       .create_hwseq = dcn321_hwseq_create,
-};
-
  static void dcn321_resource_destruct(struct dcn321_resource_pool *pool)
  {
        unsigned int i;

--
Hamza

Reply via email to