Reviewed-by: Alex Deucher <[email protected]>

On Wed, Jul 26, 2023 at 11:02 AM Srinivasan Shanmugam
<[email protected]> wrote:
>
> Use the strscpy method instead of strlcpy method.
>
> Fixes the below:
>
> WARNING: Prefer strscpy over strlcpy
>
> Cc: Christian König <[email protected]>
> Cc: Alex Deucher <[email protected]>
> Signed-off-by: Srinivasan Shanmugam <[email protected]>
> ---
>  drivers/gpu/drm/radeon/radeon_atombios.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c 
> b/drivers/gpu/drm/radeon/radeon_atombios.c
> index 697a5989c045..85c4bb186203 100644
> --- a/drivers/gpu/drm/radeon/radeon_atombios.c
> +++ b/drivers/gpu/drm/radeon/radeon_atombios.c
> @@ -2105,7 +2105,7 @@ static int radeon_atombios_parse_power_table_1_3(struct 
> radeon_device *rdev)
>                         const char *name = 
> thermal_controller_names[power_info->info.
>                                                                     
> ucOverdriveThermalController];
>                         info.addr = 
> power_info->info.ucOverdriveControllerAddress >> 1;
> -                       strlcpy(info.type, name, sizeof(info.type));
> +                       strscpy(info.type, name, sizeof(info.type));
>                         i2c_new_client_device(&rdev->pm.i2c_bus->adapter, 
> &info);
>                 }
>         }
> @@ -2355,7 +2355,7 @@ static void 
> radeon_atombios_add_pplib_thermal_controller(struct radeon_device *r
>                                 struct i2c_board_info info = { };
>                                 const char *name = 
> pp_lib_thermal_controller_names[controller->ucType];
>                                 info.addr = controller->ucI2cAddress >> 1;
> -                               strlcpy(info.type, name, sizeof(info.type));
> +                               strscpy(info.type, name, sizeof(info.type));
>                                 
> i2c_new_client_device(&rdev->pm.i2c_bus->adapter, &info);
>                         }
>                 } else {
> --
> 2.25.1
>

Reply via email to