[Public] Reviewed-by: Guchun Chen <[email protected]>
Regards, Guchun > -----Original Message----- > From: SHANMUGAM, SRINIVASAN <[email protected]> > Sent: Friday, July 28, 2023 2:01 PM > To: Koenig, Christian <[email protected]>; Deucher, Alexander > <[email protected]>; Chen, Guchun <[email protected]> > Cc: [email protected]; SHANMUGAM, SRINIVASAN > <[email protected]> > Subject: [PATCH] drm/amdpgu: Fix printk() should include KERN_<LEVEL> in > 'amdgpu_atpx_verify_interface' > > Prefer dev_err over printk variant so that we get better debug info when > there are multiple GPUs in the system. > > Fixes the below: > > WARNING: printk() should include KERN_<LEVEL> facility level > + printk("ATPX buffer is too small: %zu\n", size) > > Cc: Christian König <[email protected]> > Cc: Alex Deucher <[email protected]> > Signed-off-by: Srinivasan Shanmugam <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c > index 6f241c574665..dccebe6aaad4 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c > @@ -280,7 +280,7 @@ static int amdgpu_atpx_verify_interface(struct > amdgpu_atpx *atpx) > > size = *(u16 *) info->buffer.pointer; > if (size < 8) { > - printk("ATPX buffer is too small: %zu\n", size); > + dev_err(dev, "ATPX buffer is too small: %zu\n", size); > err = -EINVAL; > goto out; > } > -- > 2.25.1
