Am 21.08.23 um 11:48 schrieb Geert Uytterhoeven:
Hi Christian,
On Mon, Aug 21, 2023 at 11:34 AM Christian König
<christian.koe...@amd.com> wrote:
Am 21.08.23 um 11:14 schrieb Geert Uytterhoeven:
On Fri, Jul 7, 2023 at 9:36 PM Geert Uytterhoeven <ge...@linux-m68k.org> wrote:
On Fri, Jul 7, 2023 at 2:06 PM Christian König
<ckoenig.leichtzumer...@gmail.com> wrote:
Am 06.07.23 um 10:36 schrieb Geert Uytterhoeven:
On 32-bit:
../tests/amdgpu/amdgpu_stress.c: In function ‘alloc_bo’:
../tests/amdgpu/amdgpu_stress.c:178:49: warning: format ‘%lx’ expects
argument of type ‘long unsigned int’, but argument 4 has type ‘uint64_t’ {aka
‘long long unsigned int’} [-Wformat=]
fprintf(stdout, "Allocated BO number %u at 0x%lx, domain 0x%x, size
%lu\n",
~~^
%llx
num_buffers++, addr, domain, size);
~~~~
[...]
Fix this by using the proper "PRI?64" format specifiers.
Fixes: d77ccdf3ba6f5a39 ("amdgpu: add amdgpu_stress utility v2")
Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
Well generally good patch, but libdrm changes are now reviewed by merge
request and not on the mailing list any more.
I heard such a rumor, too ;-)
Unfortunately one year later, that process is still not documented in
https://gitlab.freedesktop.org/mesa/drm/-/blob/main/CONTRIBUTING.rst
which still instructs me (a casual drive-by developer) to just submit
my patches to the mailing list...
So a few weeks ago I created gitlab PRs for all my pending libdrm
patch series, and I rebased them regularly when needed.
What needs to be done to get them merged?
You need to ping the userspace maintainers for this. Like Marek,
Pierre-Eric etc..
Thanks, I assume (from "git shortlog") you mean Marek Olšák and
Pierre-Eric Pelloux-Prayer?
Yes, of course.
How do I find out the maintainers for non-amd parts?
That's a really good question, I don't have the slightest idea either.
My approach getting libdrm patches upstream used to be asking somebody
for review and then pushing them.
But that was way before switching to merge requests. Since then I have
at maximum merged a handful of patches.
Looks like this thread is becoming a "what is missing in
CONTRIBUTING.rst?" list ;-)
Indeed!
Cheers,
Christian.
Thanks again!
Gr{oetje,eeting}s,
Geert
