[
http://jira.amdatu.org/jira/browse/AMDATU-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10402#comment-10402
]
Ivo Ladage - van Doorn commented on AMDATU-176:
-----------------------------------------------
Some comments:
- In FSTenantStorageProvider m_logService is defined but not used. I would like
to see some debug statements added.
- In FSTenantStorageProvider some minor coding violations; instance variables
m_LogService, m_DataDirectory and m_TenantIdList should be named m_logService,
m_dataDirectory and m_tenantIdList (mind the capital)
- In FSTenantStorageProvider you are using a String hashcode as unique
identifier, but a String hashcode is not guaranteed unique. Why are you not
using the tenant id itself?
> Implement filebased storage for tenant management
> -------------------------------------------------
>
> Key: AMDATU-176
> URL: http://jira.amdatu.org/jira/browse/AMDATU-176
> Project: Amdatu
> Issue Type: New Feature
> Components: Amdatu Core - Tenant
> Affects Versions: 0.0.5
> Reporter: Bram de Kruijff
> Assignee: Ivo Ladage - van Doorn
> Fix For: 0.0.6
>
>
> Create a bundle (tenantstore-fs) that implements and publishes a filebased
> storage provider for the TenantStorageProvider SPI (@see AMDATU-130).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
