Make OAuthServiceConsumerRegistry API consistent
------------------------------------------------
Key: AMDATU-268
URL: http://jira.amdatu.org/jira/browse/AMDATU-268
Project: Amdatu
Issue Type: Improvement
Components: Amdatu Auth
Reporter: Bram de Kruijff
While refactoring storage under AMDATU-263 I noticed: The
OAuthServiceConsumerRegistry API has a rather extensive set of exceptions to be
thrown signifying duplicate consumers (ConsumerAlreadyExistsException) ,
inexisting consumers (ConsumerNotFoundException) as well as a generic storage
problem (ConsumerRegistryStorageException). There are however the two methods
dealing with acess (grantResourceAccess / withdrawResourceAccess) that do not
throw ConsumerNotFoundException when an update is attempted on a non existing
consumer. In fact withdrawResourceAccess has void return type so there is
actually no way of determining wether the invocation had any effect at all. It
seems a little inconsistent and I'd suggest adding ConsumerNotFoundException
when updated on non existing consumers are attempted. Under I AMDATU-263 I only
resolved the potential NPEs in this code.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
