[
http://jira.amdatu.org/jira/browse/AMDATU-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bram de Kruijff closed AMDATU-282.
----------------------------------
Assignee: Ivo Ladage - van Doorn (was: Bram de Kruijff)
<quote>
- AbstractHandler lines 70-72 contain unnecessary casts as the map is already
typed <String, String>
</quote>
resolved
<quote>
- In AbstractHandlerRegistry line 104 a new DefaultHttpContext is returned when
the service reference has no contextId property. So this method returns a
different instance each time it is invoked for the same ServiceReference. I'm
not sure if that is the intention.
</quote>
I think this is ok. When no shared contextId is requested each gets his own
context.
<quote>
- In DispatcherServiceActivator the LogService is defined as a required
dependency, but the DispatcherServiceImpl checks if the LogService is null
before using it (sometimes and sometimes not).
</quote>
Due to strange dependencymanager contract where sometimes I got NPE with
optional dependecies. I believe now that you can trust depman to inject a
NullObject except for in the update method.. not sure though. Leaving it as is,
cause there is no harm.
<quote>
- In DispatcherServiceImpl line 92 ServletException is rethrown as Exception,
why?
</quote>
What other type would I wrap it in then the most general type specified by the
method signature? Seems irrelevant to me.
> Integrate web dispatcher project
> --------------------------------
>
> Key: AMDATU-282
> URL: http://jira.amdatu.org/jira/browse/AMDATU-282
> Project: Amdatu
> Issue Type: New Feature
> Components: Amdatu Web
> Affects Versions: 0.1.0
> Reporter: Bram de Kruijff
> Assignee: Ivo Ladage - van Doorn
> Fix For: 0.1.0
>
>
> Implementation and integration of a web dispatcher mechanism that support
> pluggable (servlet/request) context extenders and tenant aware dispatching to
> web component. As described at
> http://lists.amdatu.org/pipermail/amdatu-developers/2011-January/002341.html
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
