[
http://jira.amdatu.org/jira/browse/AMDATU-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bram de Kruijff reopened AMDATU-407:
------------------------------------
Assignee: Ivo Ladage - van Doorn (was: Bram de Kruijff)
- Bug is real
- Solution is correct
- Reopening because I am not happy with the implementation
1) The implementation style is inconsistent with other methods in same class
that deal with the same issue (eg. getMembers). It does so by actually
introducing a new helper method toMap that effectively duplicates the existing
dictionaryToMap used elsewhere.
2) The code in this module is under test with a pretty high coverage. In the
spirit of our QA guidelines newly found and resolved bugs should be tested and
covered to prevent reintroduction.
> FS UserAdmin store throws ClassCastException in integration test
> ----------------------------------------------------------------
>
> Key: AMDATU-407
> URL: http://jira.amdatu.org/jira/browse/AMDATU-407
> Project: Amdatu
> Issue Type: Bug
> Components: Amdatu Core
> Affects Versions: 0.3.0-M0
> Reporter: Ivo Ladage - van Doorn
> Assignee: Ivo Ladage - van Doorn
> Fix For: 0.3.0-M0
>
> Attachments: AMDATU-407-proposed.patch
>
>
> The Auth integration test currently fails, see
> http://bamboo.amdatu.org/bamboo/browse/AMDATU-AMDAUTHTRUNK-JOB1-49/log
> . The error is caused by a dirty classcast in Pax UserAdmin, from Role to
> RoleImpl. Since the FS implementation returns an FSUser (implementing Role),
> casting it to RoleImpl fails. Stacktrace:
> 03-Aug-2011 15:19:51 org.amdatu.core.useradminstore.fs.internal.FSUser
> cannot be cast to org.ops4j.pax.useradmin.service.internal.RoleImpl
> 03-Aug-2011 15:19:51 java.lang.ClassCastException:
> org.amdatu.core.useradminstore.fs.internal.FSUser cannot be cast to
> org.ops4j.pax.useradmin.service.internal.RoleImpl
> 03-Aug-2011 15:19:51 at
> org.ops4j.pax.useradmin.service.internal.AuthorizationImpl.getRoles(AuthorizationImpl.java:77)
> 03-Aug-2011 15:19:51 at
> org.amdatu.authorization.useradmin.rest.bean.RoleBean.fromRole(RoleBean.java:154)
> 03-Aug-2011 15:19:51 at
> org.amdatu.authorization.useradmin.rest.bean.RoleBean.fromRole(RoleBean.java:137)
> 03-Aug-2011 15:19:51 at
> org.amdatu.authorization.useradmin.rest.service.ResourceBase.getRole(ResourceBase.java:230)
> 03-Aug-2011 15:19:51 at
> org.amdatu.authorization.useradmin.rest.service.UsersResource.getUser(UsersResource.java:141)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
