[
http://jira.amdatu.org/jira/browse/AMDATUOPENSOCIAL-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11883#comment-11883
]
Ivo Ladage - van Doorn commented on AMDATUOPENSOCIAL-137:
---------------------------------------------------------
Review of new v3 patch:
- The included jquery.cookie.js file is copyright protected by Klaus Hartl,
2009. It is licensed under MIT, so including it is no problem. But since it is
an attribution, it should be mentioned in the NOTICE file.
- In jquery.dashboard.js, addWidget method the input argument 'index' may be
'undefined'. If so, "column.trigger('updateWidgetIndexes');" is executed but
the method continues and sets the index on 'undefined' when setting it on the
dashboard later on. Couldn't that cause issues?
- There is still something wrong with the widgets displayed in the 'Add widget'
popup in dashboard_multiple.html. To reproduce; start clean, add dashboard,
open add widget dialog, select 'Another category'. Now it says that it contains
1 widget on the left but displays two of them on the right. When I click on 'My
category' it says two on the left but I see 4 of them on the right. And when I
add a widget, it is added twice.
- Order of gadgets is still not preserved in IE. To reproduce, open
dashboard_multiple.html and move the 'Examples' widget above the
'Documentation' widget and refresh.
- In firefox, the ordering of gadgets changes after maximizing/minimizing a
gadget. To reproduce, start clean, open dashboard_multiple.html, maximize the
'Download plugin' widget, minimize the 'Download plugin' widget
- I expected some new features in this version like remove and move dashboards.
Would be nice to have these features included in the patch.
> Improve multiple dashboard demo
> -------------------------------
>
> Key: AMDATUOPENSOCIAL-137
> URL: http://jira.amdatu.org/jira/browse/AMDATUOPENSOCIAL-137
> Project: Amdatu OpenSocial
> Issue Type: Improvement
> Reporter: Mark Machielsen
> Attachments: AMDATUOPENSOCIAL-137.patch,
> AMDATUOPENSOCIAL-137-v2.patch, AMDATUOPENSOCIAL-137-v3.patch
>
>
> Currently the dashboard_multiple.html is not feature complete. Please add the
> following features:
> - add possibility to add dashboards
> - select the dashboard which is added
> - make sure the widget are added to the correct dashboard
> - store the dashboards and which widgets are on what tab in a cookie
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
