Code review: useradmincache
---------------------------
Key: AMDATU-512
URL: http://jira.amdatu.org/jira/browse/AMDATU-512
Project: Amdatu
Issue Type: Improvement
Components: Amdatu Core
Reporter: Jan Willem Janssen
Fix For: Backlog
My comments:
* why bother creating a caching aspect for useradmin if the implementation has
performance issues? Shouldn't we provide a patch to overcome this in the
original useradmin service?
* CachedAuthorization#hasRole(): who is supposed to understand this without a
single line of comment?! Wouldn't a concurrent version of the m_hasRoleCache be
sufficient?
* CachedGroup: wouldn't a concurrent version of the List-interface suffice?
* CachedUser: idem
* UserAdminCache: idem
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers