[
http://jira.amdatu.org/jira/browse/AMDATU-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bram de Kruijff updated AMDATU-508:
-----------------------------------
Estimated Eng Workload: 2
> Code review: itest.base
> -----------------------
>
> Key: AMDATU-508
> URL: http://jira.amdatu.org/jira/browse/AMDATU-508
> Project: Amdatu
> Issue Type: Improvement
> Components: Amdatu Core
> Reporter: Jan Willem Janssen
> Labels: code_review
> Fix For: Sprint 2
>
>
> My comments:
> * CoreFixture#Bundles references old/stale bundles;
> * CoreFixture#provision provisionOptions can be rewritten as:
> provisionOptions.addAll(Arrays.asList(Bundles.values());
> provisionOptions.removeAll(Arrays.asList(excludes));
> * CoreFixture#configure see previous comment;
> * CoreFixture#configure with a single argument is redundant due to the
> varargs methods;
> * TestContext misses JavaDoc on all its methods, this is a utility class for
> creating new test cases, so it should be well documented;
> * TestContext#getConfigurationAdmin() vs. TestContext#getConfigAdminService
> vs. TestContext#getConfigAdminServiceRef, why do the latter two methods
> exists and cannot they be coerced into the first method call?
> * TestContext#createContextWorkDir() is this still necessary to have? If so,
> why is there a contextDir.delete() prior to contextDir.mkdir()?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
