[ 
http://jira.amdatu.org/jira/browse/AMDATU-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12329#comment-12329
 ] 

Bram de Kruijff commented on AMDATU-529:
----------------------------------------

Most refactoring done. A few notes:

1) Not covered yet in design/documentation yet is the artifact rename to match 
packages. Also probably we should probably move the tenant modules out of the 
core module. However, at this point I left structure in tact. Moving them may 
be more appropriate when we move to git.

{code}

    <dependency>
      <groupId>org.amdatu.tenant</groupId>
      <artifactId>org.amdatu.tenant</artifactId>
    </dependency>
    <dependency>
      <groupId>org.amdatu.tenant</groupId>
      <artifactId>org.amdatu.tenant.adaptor</artifactId>
    </dependency>
    <dependency>
      <groupId>org.amdatu.tenant</groupId>
      <artifactId>org.amdatu.tenant.factory</artifactId>
    </dependency>
{code}


2) Design dictates a x- prefix for custom MANIFEST headers, which is spec 
compliant. However, that is a little more difficult to integrate in the build 
cause the bnd plugin only includes properties that start with captital letter. 
Therefore at this point I used X-.
                
> Execute refactorring based on design/reviews
> --------------------------------------------
>
>                 Key: AMDATU-529
>                 URL: http://jira.amdatu.org/jira/browse/AMDATU-529
>             Project: Amdatu
>          Issue Type: Sub-task
>            Reporter: Bram de Kruijff
>            Assignee: Bram de Kruijff
>             Fix For: Sprint 2
>
>
> Work:
> 1) Refactor Tenant API [DONE]
> 2) Refactor Web hostname resolver [DONE] 
> 3) Refactor Web parameter resolver
> 4) Refactor Tenant packages [DONE]
> 5) Refactor Tenant Adaptor props [DONE]
> 6) Check all metatype
> 7) Check all assemblies
> 8) Check review comments
> 9) Move modules to own multimodule?
> 9) Check documentation

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers

Reply via email to