[
http://jira.amdatu.org/jira/browse/AMDATU-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthijs Hendriks updated AMDATU-506:
-------------------------------------
Attachment: AMDATU-506.patch
Synchronized methods have been replaced by ´normal´ methods using synchronized
blocks.
Method runUpdateTasks is fixed
Methods start/stop no longer logs redundant information
Code is split into several classes; all task (implementations) are moved out of
the TenantAutoConfResourceProcessor
Coding guidelines are now applied to all code
The code is not (re?)tested
Methods process/dropAllResources/prepare/commit still call (possibly dangerous)
framework methods.
> Code review: deployment.tenantconf
> ----------------------------------
>
> Key: AMDATU-506
> URL: http://jira.amdatu.org/jira/browse/AMDATU-506
> Project: Amdatu
> Issue Type: Improvement
> Components: Amdatu Core
> Reporter: Jan Willem Janssen
> Labels: code_review
> Fix For: Sprint 2
>
> Attachments: AMDATU-506.patch
>
>
> My comments:
> * code looks very similar to Felix' AutoConfResourceProcessor, as we sure we
> want to maintain our own version instead of contributing to the Felix project?
> * it appears that the implementation tries to make certain tasks "atomic" by
> synchronizing API-methods (begin, cancel, commit, and so on). This does not
> work as intended! Possible deadlocks might occur when other OSGi framework
> code is called.
> * runUpdateTasks has some large synchronized blocks that makes other
> framework calls; possible deadlocks!
> * the OSGi service-lifecycle methods (start/stop) are logging redundant
> information;
> * the current implementation is cramming too much code into a single class,
> with no apparent reason;
> * coding guidelines are not applied to all code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
