[ 
http://jira.amdatu.org/jira/browse/AMDATU-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12357#comment-12357
 ] 

Bram de Kruijff commented on AMDATU-504:
----------------------------------------

{quote}
coming up with a proposal for the new naming and document it
{quote}

There is 
http://www.amdatu.org/confluence/display/Amdatu/Internal+naming+conventions 
which state that the scheme is basically just 
org.amdatu.<subProjectName>.<artifactName>

I don't think this is wrong. The "mistake" we made was putting all kind of 
stuff in a "core" subproject where it really just isn't a logical/conceptual 
one. I think this was motivated because at the time we thought it might be and 
did not want to get an enormous list of modules in the root liek for exmaple 
Felix has.

What I think has changed is that we now know core is not a logical subproject. 
Eg. tenant is optional, there is no strict relation with its peers. Also a 
proposed move to git would lessen the many modules concerns as it would probaly 
splitting into multiple repositories.

So my view is that we can more or less keep the existing guideline and just 
kill the "core" subprojects and splitting it out into logical ones.

A first proposal in line with what we have effectively done for the revised 
tenant design:

org.amdatu.tenant/org.amdatu.tenant
org.amdatu.tenant/org.amdatu.tenant.factory
org.amdatu.tenant/org.amdatu.tenant.adapter
org.amdatu.fileinstall/org.amdatu.fileinstall.autoconf
org.amdatu.useradmin/org.amdatu.useradmin
etc.

Then there is still the question of how to structure that in file layout. 
Intuitively I'd suggest maintaining a submodule per subprojects. Eg all tenant 
module under one module root because that allows for shared default betweenn 
logically related modules. As a default without making it a law.

{quote}
refactoring the platform to conform with this naming
{quote}

This is inline with how we refactorred tenant (besides the fs layout). We wont 
make it for all remaining modules in this sprint though. Time's up.

{quote}
giving some guidance to subprojects in how they can quickly adapt to the new 
naming
{quote}
I think not much change is need



                
> Rethink package names for the platform
> --------------------------------------
>
>                 Key: AMDATU-504
>                 URL: http://jira.amdatu.org/jira/browse/AMDATU-504
>             Project: Amdatu
>          Issue Type: Task
>            Reporter: Marcel Offermans
>             Fix For: Sprint 2
>
>
> Take a critical look at our package naming. It was suggested to remove the 
> "core" part of the name, so "org.amdatu.core.XYZ" will just become 
> "org.amdatu.XYZ" instead. This task includes:
> * coming up with a proposal for the new naming and document it
> * refactoring the platform to conform with this naming
> * giving some guidance to subprojects in how they can quickly adapt to the 
> new naming

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers

Reply via email to