[
http://jira.amdatu.org/jira/browse/AMDATU-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12498#comment-12498
]
Bram de Kruijff commented on AMDATU-520:
----------------------------------------
{quote}
why is this bundle made and not making use of PAX-Web JSP? The more code we can
reuse, the less code we need to maintain;
{quote}
Not sure why this approach was chosen. You are welcome to provide an
alternative ;)
{quote}
JspSupport is a marker interface, please remove
{quote}
Will do
{quote}
JasperClassLoader#getClassPathJars uses url.toExternalForm() twice without an
intermediary variable;
{quote}
Does it really matter? The url is final.. will fix.
{quote}
ResourceProviderJspServlet declares unnecessary serialVersionUID, Servlet isn't
Serializable (anymore);
{quote}
Will remove
{quote}
I don't see any code instructing Jasper to be multi-tenant aware; this is bound
to fail.
{quote}
Multi-Tenancy is on the servlet layer (1 per tenant). but this mechanism is not
yet Multi-tenancy proof.
> Code review: web.jsp
> --------------------
>
> Key: AMDATU-520
> URL: http://jira.amdatu.org/jira/browse/AMDATU-520
> Project: Amdatu
> Issue Type: Improvement
> Reporter: Jan Willem Janssen
> Labels: code_review
>
> My comments:
> * why is this bundle made and not making use of PAX-Web JSP? The more code we
> can reuse, the less code we need to maintain;
> * JspSupport is a marker interface, please remove
> * JasperClassLoader#getClassPathJars uses url.toExternalForm() twice without
> an intermediary variable;
> * ResourceProviderJspServlet declares unnecessary serialVersionUID, Servlet
> isn't Serializable (anymore);
> * I don't see any code instructing Jasper to be multi-tenant aware; this is
> bound to fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
