[ 
http://jira.amdatu.org/jira/browse/AMDATU-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bram de Kruijff reopened AMDATU-556:
------------------------------------

      Assignee: Jan Willem Janssen  (was: Bram de Kruijff)

Some questions:

You are using "platform service" for "global" services, right? So services with 
a property "platform.service=true" are not so much services of the platform 
tenant? I'm confused ;) Would "global" not be more suitable?

The one service that by default has property "platform.service=true" is the 
tenant factory's ManagedServiceFactory componenent. I think this is incorrect? 
Why should we expose this to tenant and effectively allow them to mess with it?

The adapter does not support creating "platform/global" services? I think the 
point of this property is to allow applications to define "singleton" "global" 
services in their applications by placing it in the platform scope but exposing 
the service to all tenants.

Wiki not updated
                
> Remove reference to web in TenantAdapter
> ----------------------------------------
>
>                 Key: AMDATU-556
>                 URL: http://jira.amdatu.org/jira/browse/AMDATU-556
>             Project: Amdatu
>          Issue Type: Sub-task
>          Components: Amdatu Core
>            Reporter: Marcel Offermans
>            Assignee: Jan Willem Janssen
>             Fix For: Sprint 4
>
>
> TenantAdapter has the following method:
> {code}
>     protected String getTenantFilter() {
>         return "(|(objectClass=org.amdatu.web.rest.jaxrs.JaxRsSpi)"
>             + "(objectClass=org.osgi.service.log.LogService)("
>             + PID_KEY + "=" + getTenantPID() + "))";
>     }
> {code}
> I don't understand why a tenant filter must contain a hardcoded reference to 
> some amdatu web service. If we need a mechanism to work around a bug, then at 
> least we should generalize the fix to be broader than just JAX-RS. Quite 
> frankly, I still hope we find a better solution.
> Second thing: Why does it make a specific exception for LogService? This 
> states that you never want to make LogService tenant specific, which is a 
> choice we should not make for our users.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers

Reply via email to