Hello Matthias, Matthias Trute <mtr...@web.de> writes:
> Hi Enoch, > >> > Only one remark so far. > > And now my second one. Its more a vague > idea, not a streamlined chain of reason including > a smart solution. Sorry. > > It is related to the way, the > newly created word list entry is linked into it. > HEADER gets the WID for which the new word > is created. The same WID is used later on to be > stored into the same wordlist: The surprising and > "unmotivated" XT_STOREE in words that call > (CREATE) like VARIABLE etc. Withing these words > there is nothing that could explain it. IMHO. > > At the first glance there is no reason to duplicate and > decentralize the STOREE, but there is one, rather far away: > Colon word definitions are hidden until the semicolon is > executed. And the way, the search wordlist (get-order) > is handled if the compile-to wordlist (Current) contains one > of the get-order's entries. > > What I would like to have is a single place where the new word > is defined and linked into the right wordlist. Its probably simple, > but far from trivial. I'll think about it. > > Its a fascinating change. Much more demanding than I thought > initially... > > Matthias > > PS: simply said: just change the stack effect of HEADER from > (addr len wid -- wid) to something better ;) #1 There is a strong argument to merge XT_HEADER with XT_DOCREATE as XT_HEADER is called only by XT_DOCREATE. That's what Mr. KISS always says :-) #2 As for "wlscope" stack effect, if the price for our AmForth idea to be admitted to the Forth community "hall of fame" (forth200x.org, that is) would be for wlscope to consume its arguments, so be it: We can do it neatly (i.e., without irritating ol' Mr. KISS) by rearranging the order of activities in XT_HEADER and call XT_WLSCOPE after the name-string validity check (non-empty) and after creating the dictionary header in Flash (i.e., just before linking). #3 Based on your response to #1 I can submit a patch, if you like. Your code is, as you say, indeed dark (not enough comment lampposts) but is quite easy to read! Regards, Enoch. ------------------------------------------------------------------------------ Own the Future-Intel(R) Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2 _______________________________________________ Amforth-devel mailing list for http://amforth.sf.net/ Amforth-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amforth-devel
