Hi,

> May I suggest renaming the new implementation of imove
> ( i-addr len ram -- ) at lib/ans94/core/imove.frt to icmove:

Uhm. The naming I'd like to delay. There are some
efforts to get a consistent naming convention for
memory accesses. One example is
http://www.forth200x.org/memory-2010-06-26.txt

> Also, it seems to me that your implementation may cause ram buffer
> overflow.

The code copies flash cells. That may overrun the
RAM if an odd number of bytes is transferred. Thats
bad indeed.

Matthias


------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Amforth-devel mailing list for http://amforth.sf.net/
Amforth-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amforth-devel

Reply via email to