hehe, thx Tom!
I do have 0 gui skills as in 0 interface design skills..
for PSMs, I just copied official client's design :P
but about playing with pack/grid/tk commands, no prob :P

KKRT


On Wed, 01 Feb 2006 14:37:29 -0500, Tom Jenkins <[EMAIL PROTECTED]> wrote:

Youness Alaoui wrote:

lol!
thx to both of you (and in advance, to all other who might also put their words in the thread:P) I tried my best to fix the little things.. I tried to find the memleak with searching for 'image create photo' that never gets deleted, couldn't find much, but found some issues with images.. fixed those.. then the isAnimated.. found the fix I talked about in the dps_in_cl, then.. etc.. and I ended up with a lot of little things.. it didn't speed up the CL that much (if you disable smileys in CL, it gets fast though!).. we don't have any more flickering of the CL when it's refreshed (that's from Phil's fix I think) only the top bar flickers, and I think we need to fix that (I know the canvas is recreated each time, so I guess the other windows too.. this should be made so that it's not destroyed/recreated.. but instead it should be cleared and text should be 'delete 0.0 end'.. that's still one improvement to be done!

Well done on the gui job!! And you say you have 0 gui skills ;)


yes.. diff is huge.. but not too complicated (I think..)
good luck for the QA team :P

KKRT


On Wed, 01 Feb 2006 12:47:47 -0500, Vivia Nikolaidou <[EMAIL PROTECTED]> wrote:


I noticed this too - very long, and i'll have to study the diff :D

congrats Youness!!!!!!!    <-- yes, many exclamation marks

On Wed, 1 Feb 2006, Jérôme Gagnon-Voyer wrote:

Before we got the "long message", now we get the "longest commit message ever"
:D

I'm very happy of all the changes you did, optmization of the actions we do
frequently (like reloading contact list) is very important.

aMSN should run a little faster now (or takes less CPU, or both!), and I know
that a lot of users will love that :P


Le 1 février 2006 à 11:50, Alaoui Youness a écrit :

> Logo animation on connect now uses ::skin::loadPixmap to avoid
> deleting/recreating the image everytime..
> Logo animation on connect is now an inserted image instead of a label
> with an image..
> clicableImages (in CL and chatwindows, like the mailbox button for
> example) are now an image inserted into the text instead of being an
> image in a label  and the label being inserted...
> cleaned up some code for getClicableDisapplyPicture..
> my DP and my smaller DP (resized for the CL) are now recreated only if
> the DP changed, not everytime the CL is updated...
> Our own PSM is now bold/italic in the CL
> Some code cleaning...
> check for globalnick before inserting PSM...
> We now check if the DP of users is animated ONLY if we have DPs in CL
> and if the small_dp doesn't already exist!
> We now have a cache for checking animated files, since a file will
> rarely change, and we don't want to open/close a gif everytime, in case
> we already know if it's animated
> Changed some "catch {image width}" into "lsearch [image names]" to avoid
> the catch failing which is cpu intensive (compared to lsearch...)
> Now, getDisplayPicture returns the no_pic image, instead of copying the > no_pic image into the user's image, this way, we won't create useless
> images and a user without a DP has no image for him.. cleaner code I
> think.. NEEDS TESTING!
> The colorbar under the mail line of CL is now saved and is not
> regenerated unless the CL width changed..
> deleting the preview images used by the skin selector once it's
> destroyed.
>
>
> OUPS : REverted back my changes from the catch {image width} to
> lsearch... it seems, Arieh is
> right and it is far faster to use the catch instead of the search.. even
> if the catch is itself
> cpu consuming, the lsearch is even more cpu consuming... changed it back
> and merged my change with
> his fix on the search for image names for the DPS in CL




---

"Where is the life that we have lost in living?
 Where is the wisdom that we have lost in knowledge?
 Where is the knowledge that we have lost in information?"

OEO;









--
KaKaRoTo


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel

Reply via email to