On Thu, 02 Feb 2006 11:31:59 -0500, Tom Jenkins <[EMAIL PROTECTED]> wrote:

Youness Alaoui wrote:

cool for regexp :D but lol at hex.. I was about to say don't pay attention to it but then totally forgot when I sent the mail.. no, hex search is NOT necessary, and I wouldn't want it.. it's there because it's the search of 'lister', which is mostly used as a hex viewer... that's why i sent it.. I also sent the screeny to show how you could replace your radiobuttons into one "search backwards" checkbutton.. and I don't know if it's there yet or no, but the ignore case also...

I don't like the idea of replacing the two radiobuttons with a "search backwards" checkbutton. I always imagine it finding the actual word backwards...so if I search for Hello it will look for olleH :P


ok, u decide ;)

that's all!
please, don't do the hex thing.. crazy as you are, I'm sure I'll see it on tomorrow's commit :P

;)


p.s.: if whole word only is checked, make the search string into a "\b$search\b" and use -regexp... \b meaning word boundaries (could be a comma, a dot, a colon, a space, a tab, a newline, etc...)

Thanks! I have a question though...I don't know much about regexps but if the search pattern has some stuff in that rexegp will compile then won't it mess it up? I mean say a use has searched for "Hello?Tom!" and they have checked "whole words only", but not "use as regular expression", the search will look for "HellTom!" and "HelloTom!", instead of "Hello?Tom!" no?


you're right.. that's why reserved chars should be escaped.. maybe there's a way to fix that without creating a proc that escapes everything.. you could look for it (maybe "\b{?x:$search)\b") where 'x' would be a modifier to regexp that would tell it to consider the string as literral (s -> dot matches all, i -> not case sensitive, etc...) if you can't find it, then you'll have to use another method, like each time you find a match, you check for the letter before and after, if it's [\s\p] (not sure if \p exists in tcl regexp, but should be for punctuations)

KKRT


KKRT

On Wed, 01 Feb 2006 18:13:56 -0500, Tom Jenkins <[EMAIL PROTECTED]> wrote:

Youness Alaoui wrote:

On Wed, 01 Feb 2006 17:20:03 -0500, Tom Jenkins <[EMAIL PROTECTED]> wrote:

Jérôme Gagnon-Voyer wrote:

So, to conclude, "I like the way you do that right therrrr" :D.

I'm feeling that love man... (H)
Btw, is the search dialog okay for everyone? No bugs/problems/ features missing?

Tom


in fact.. some feats :P I'm not requesting them.. just giving ideas from another soft I got here :
screenshot attached...
btw, leave the regexp thing, if regexp enabled, maybe search entry has red background or whatever.. if regexp compilation fails, either ignore it and it would be like a "not found", or popup a "regexp could not be compiled" or something..
that's for when you'll bored :)


Hehe okay, I'll put regexp back tomorrow. About the other two options (whole words and hex string) - haven't added those because $text search didn't include them (and I hadn't thought of hex anyway :D don't suppose many will want that, dunno if you were actually suggesting it either?). Whole words would be easy though, just check for whitespace left and right of string when it's found, I'll do that tomorrow I guess.
Thanks for the feedback!
Tom




------------------------------------------------------------------------










--
KaKaRoTo


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel

Reply via email to