On Wednesday 22 March 2006 04:59, Arieh Schneier wrote: > The plugin system needed a good workover, well done Karol for doing it, and > Vivia for testing/fixing. I would really like to take a look at the changes > myself, but have been so swamped lately I haven't had time for anything. > > Did you take a look at trying to change the lists to arrays (similar to > what I did for event system), it would be much, much faster than searching > through lists for every 2nd function. > What do you mean? Anywas, I think the next step should be to integrate the two events systems together. Do you think that would be a good idea? > > ----- Original Message ----- > From: "Vivia Nikolaidou" <[EMAIL PROTECTED]> > To: <amsn-devel@lists.sourceforge.net> > Sent: Wednesday, March 22, 2006 8:44 PM > Subject: Re: [Amsn-devel] Plugin System Changes > > > On Tue, 21 Mar 2006, Karol Krizka wrote: > > > About the corrupt plugins.xml freezing aMSN, this is something to be > > > looked into. I will add it to my TODO list. > > > > I still have my corrupt plugins.xml at home, so I can send it tonight > > (<-- note to self!). I think some other user had the same problem on the > > forums btw... > > > > > > 2) For some reason, many plugins required to appear as loaded (in > > > > list loadedplugins) in order for their init proc to work, and > > > > unloaded in order for their deinit proc to work. I moved > > > > lappend/lreplace before init/deinit , but I'm not too sure if this is > > > > the correct solution... > > > > > > Ahh yes, because the RegisterEvent checks if the plugin is loaded. Also > > > I think that addig it to loadedplugins should be done before checking > > > if the plugin has a Init proc because otherwise we would have to > > > duplicate it if there wasn't an init proc > > > > Well, it returns -1 if there is no init procedure... so I suppose it's > > not loaded at all in this case, right? OK, you know better than I do > > anyway, so do whatever you think is best. I didn't test with many plugins > > yesterday. > > > > > > 3) GUI issue only: when you selected to load/unload the plugin, its > > > > color on the list didn't change until you closed/reopened the > > > > window. Fixed this. > > > > > > Hum, I though GUI_NewSel took care of it. I must have missed it. I > > > think it should be part of it though, so all "updating" of the > > > selection is taken care of in one proc. > > > > > > Btw, would it be possible to change the color? I think is very close to > > > white and hard to see. Maybe that's why I missed this bug. > > > > Increase your screen's contrast :P Seriously, change it if you want (I > > suppose other people have the same problem, though I don't), but make > > sure it's not too dark, so the text remains readable. Maybe you can make > > it yellow-greenish, to take advantage of the eye's sensitivity. > > > > > I am also working on fixing the bug report sent earlier but since I am > > > not familiar with how the autoupdate works this will take a day or two. > > > What I talked about in this email will be commited with the fix for the > > > bug. > > > > I saw it 10 minutes yesterday: there are 2 calls to > > ::plugins::findplugins , one in autoupdate.tcl and one in plugins.tcl, > > and this proc got deleted. As far as I could understand, it just used to > > return a list with all the plugins that there are. So, either bring back > > this proc or replace these calls with another way to fetch a list of all > > plugins. > > > > Vivia > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by xPML, a groundbreaking scripting > > language > > > that extends applications into web and mobile media. Attend the live > > webcast > > > and join the prime developer group breaking into this new coding > > territory! > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > > _______________________________________________ > > Amsn-devel mailing list > > Amsn-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/amsn-devel > > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking scripting language > that extends applications into web and mobile media. Attend the live > webcast and join the prime developer group breaking into this new coding > territory! > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > _______________________________________________ > Amsn-devel mailing list > Amsn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/amsn-devel
-- Karol Krizka
pgp6cBCVsX2FG.pgp
Description: PGP signature
