Le Tuesday 27 June 2006 23:07, Youness Alaoui a écrit :
> Thanks!
> My mistake, I didn't know what stubs were at the time I made the extension
> (but weirdly enough, I initialized the Tk stubs...)
> I just noticed something in your diff, first, the Tcl/Tk stubs you
> initialized like this :
> - if (Tk_InitStubs(interp, "8.3", 0) == NULL) {
> + //Check Tcl version
> + if (Tcl_InitStubs(interp, TCL_VERSION, 0) == NULL) {
>
> you used TCL_VERSION, which will prevent anyone using the extension with
> another version of tcl/tk. It was necessary for TkCximage and Webcamsn
> because they both use Tk_PhotoPutBlock, but Winflash doesn't use this API
> (which changed signature from 8.3 to 8.4 and to 8.5), so it can work on
> virtually any 8.X tcl/tk version.
> Also, you did change it into TCL_VERISON and TK_VERSION, but it wouldn't
> have worked, because you kept the 'strict' argument to flase (the 0 should
> have become 1 if you wanted to use strcitly the verison it was compiled
> for).
I did like you did in TkCxImage... Apart for the strict flag... But you forget
some thing (hum... I just think I will need to recompile TkCxImage) windows
DLLs are compiled by us and not by users so if for whatever reason the user
wants to upgrade its wish he will have to recompile the DLLs so I think it's
better to use the not strict flag....
>
> One last comment, I saw you fixed some C++ syntax into C syntax, is it
> only to avoid 'creation' of a variable (j) for every loop ? or is it to be
> C compliant ? in either case :
> 1 - the compiler will optimize the code so no need to make j a variable
> outside the scope of the for loops
> 2 - the file is named .cpp so we don't need to be C compliant
> 3 - the code is still not C-compliant, since we have comments with //
> while C supports only /* */ comments...
Hum not really... in fact it was to prevent a compilation with VC++6...
You said and you are right if you have a standard version of VC++6 that you
can't compile winflash with it because it hasn't the good headers....
But, and it's why I think it's problematic to provide the DSP for winflash, I
had to use the Windows2003 SDK downloaded (for free) on M$ site...
So you can compile winflash with VC++6 but with the newer SDK...
That's all !
>
> that's all, I would prefer the stubs to be made on 8.3+ because I know
> winflash is used by at least another project outside fo amsn's scope, so
> it would be best to ease it for him as long as it's possible.
> the other comments were just comments, no code change needed.
>
> Tanks,
> KKRT
Phil
P.S. OOps just saw that I replied to your 2 mails... :d
>
>
> On Tue, 27 Jun 2006 16:21:17 -0400, Philippe Valembois - Phil
>
> <[EMAIL PROTECTED]> wrote:
> > Trouble was with WinFlash...
> > I compiled without testing (because I don't like Windows so I try to
> > leave it
> > as fast it's possible)...
> > The trouble comes from the stubs (since I compiled it with stubs : it
> > was the
> > aim of my operation) it's because we didn't initialize the stubs for Tcl
> > only
> > the ones for Tk...
> > Anyway, it's fixed now...
> > And I fixed the Unicode stuff in Winutils too...
> > Phil
> >
> > Le Tuesday 27 June 2006 19:32, Sander Hoentjen a écrit :
> >> I don't see the problem with an updated amsn on windows
> >>
> >> On Tue, 2006-06-27 at 16:49 +0300, Vivia Nikolaidou wrote:
> >> > http://amsn.sourceforge.net/forums/viewtopic.php?t=1269
> >> >
> >> > Today's SVN on Windows crashes when someone tries to open a
> >> > conversation window. Maybe one of the Windows binaries Phil updated
> >> > yesterday got messed up?
> >> >
> >> > Using Tomcat but need to do more? Need to support web services,
> >>
> >> security?
> >>
> >> > Get stuff done quickly with pre-integrated technology to make your job
> >> > easier Download IBM WebSphere Application Server v.1.0.1 based on
> >>
> >> Apache
> >>
> >> > Geronimo
> >>
> >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> >>
> >> > _______________________________________________
> >> > Amsn-devel mailing list
> >> > [email protected]
> >> > https://lists.sourceforge.net/lists/listinfo/amsn-devel
> >>
> >> Using Tomcat but need to do more? Need to support web services,
> >> security?
> >> Get stuff done quickly with pre-integrated technology to make your job
> >> easier Download IBM WebSphere Application Server v.1.0.1 based on Apache
> >> Geronimo
> >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> >> _______________________________________________
> >> Amsn-devel mailing list
> >> [email protected]
> >> https://lists.sourceforge.net/lists/listinfo/amsn-devel
> >
> > Using Tomcat but need to do more? Need to support web services, security?
> > Get stuff done quickly with pre-integrated technology to make your job
> > easier
> > Download IBM WebSphere Application Server v.1.0.1 based on Apache
> > Geronimo
> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> > _______________________________________________
> > Amsn-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/amsn-devel
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Amsn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/amsn-devel
