Humm.. how about NEVER counting ... What I mean is, instead of an event to keep the count, and isntead of caling a updatecounts before the cmsn_draw_online, we could instead directly do a : ::groups::GetCount $group which will calculate it on the fly... I hate the idea of keeping the count in a variable and update that count on events.. I know it's not the most efficient thing, but I'd prefer to loose some speed compared to adding tons of bugs.. Also, it might not be that bad in performance, since the group count will be read only once per group, instead of having the event be fired, callback called, count updated for every contact action... no? + the issue of the group update callback being called before the CL update event... that would be a mess to acheive.. I would also vote for event driven window, but hey, we need to compromise! what do you think ?
KKRT On Mon, Dec 11, 2006 at 07:53:04PM +0100, Philippe Valembois - Phil wrote: > OUch just thought :s > No it can't be in protocol as it depends on display mode (eg Hybrid, Grouped > or Online/Offline) so it must be splitted > Phil > > Le Monday 11 December 2006 19:49, Philippe Valembois - Phil a écrit : > > LOl, > > I thought about that too.... > > Simpler but it's many code to add to protocol but I think it's silly to > > make the count in the oldCL code... > > Phil > > > > Le Monday 11 December 2006 19:47, Karel Demeyer a écrit : > > > Shouldn't group counts be done in the protocol layer ? I don't know > > > much of this but can't it be done by keeping these counts as variables > > > in the protocol layer which can be retrieved from other layers with a > > > call ? > > > > > > Karel > > > > > > Op maandag 11-12-2006 om 19:34 uur [tijdzone +0100], schreef Philippe > > > > > > Valembois - Phil: > > > > Hi, > > > > I know perfectly what you said... > > > > By the way you said it over MSN... > > > > But you see the same problem that me : we must take care of events > > > > perfectly because else, counts will be erroneous... > > > > But doing it through cmsn_draw_online is a really bad thing and I > > > > reject this idea... My final aim is to see this cmsn_draw_online proc > > > > disappear... I hate such things !! I vote for an event driven main > > > > window... :d So I think we must think when events are fired and when we > > > > must update counts... > > > > Another trouble is : group counting must take the precedence over the > > > > newCL because else, the counts won't be well updated... > > > > Phil > > > > > > > > Le Monday 11 December 2006 00:58, Youness Alaoui a écrit : > > > > > best thing would be whenever someone finds a bug, he fixes it.. > > > > > otherwise, we'll never get this thing done. alvaro, this bug was > > > > > explained in my earlier emails, maybe if you disable the "do not show > > > > > empty groups", you'll see that user appear... > > > > > Phil, I also think I wrote a solution for that in a previous mail, > > > > > but not sure if you didn't read it (or forgot) or if you read it but > > > > > thought it was a bad idea.. I think we should have a proc from the > > > > > groups namespace register for contact events, and update the user > > > > > count directly from the groups procs. > > > > > Another solution (would be better as it will be less buggy I suppose) > > > > > would be to have a proc in groups::UpdateUserCounts which will go > > > > > through the list of users and update all those user counts. And that > > > > > proc could be called everytime we enter cmsn_draw_online ... > > > > > The second solution would be better as it will be less buggy because > > > > > it will refresh the count according to the list itself, not depending > > > > > on some events.. the first solution would need to take account ALL > > > > > possible list changes, like a user copied from one group to another, > > > > > a user moved, a user blablabla... u know what I mean.. a little > > > > > mistake and the user count will be corrupted until you logoff/login > > > > > again. But it will be the 'best' way... > > > > > > > > > > KaKaRoTo > > > > > > > > > > On Sun, Dec 10, 2006 at 02:03:37PM +0100, Philippe Valembois - Phil > > > > wrote: > > > > > > It's a know trouble as the count of contacts was done in oldCL > > > > > > code... We must implement that but I still don't know well how I > > > > > > will implement that... So either you code it either you wait for me > > > > > > to find time and code it... Phil > > > > > > > > > > > > Le Sunday 10 December 2006 13:57, Álvaro J. Iradier a écrit : > > > > > > > Hi, a contact that is in no groups came online, but it was > > > > > > > invisible in the contact list when in "hybrid mode". The contact > > > > > > > was there in standard or group mode, but not in hybrid mode. When > > > > > > > moving the user to a group, it appears correctly in the new > > > > > > > group. > > > > > > > > > > > > > > Is it possible that the "No group" group is not shown correctly? > > > > > > > > > > > > > > Also, the user count in every group is not updated correctly > > > > > > > (maybe this is why the "No group" group is not shown, as it > > > > > > > thinks there are 0 users). > > > > > > > > > > > > ------------------------------------------------------------------- > > > > > >-- ---- Take Surveys. Earn Cash. Influence the Future of IT > > > > > > Join SourceForge.net's Techsay panel and you'll get the chance to > > > > > > share your opinions on IT & business topics through brief surveys - > > > > > > and earn cash > > > > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID= > > > > > >DE VDEV _______________________________________________ > > > > > > Amsn-devel mailing list > > > > > > Amsn-devel@lists.sourceforge.net > > > > > > https://lists.sourceforge.net/lists/listinfo/amsn-devel > > > > > > > > > > --------------------------------------------------------------------- > > > > >-- -- Take Surveys. Earn Cash. Influence the Future of IT > > > > > Join SourceForge.net's Techsay panel and you'll get the chance to > > > > > share your opinions on IT & business topics through brief surveys - > > > > > and earn cash > > > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DE > > > > >VD EV _______________________________________________ > > > > > Amsn-devel mailing list > > > > > Amsn-devel@lists.sourceforge.net > > > > > https://lists.sourceforge.net/lists/listinfo/amsn-devel > > > > > > > > ----------------------------------------------------------------------- > > > >-- Take Surveys. Earn Cash. Influence the Future of IT > > > > Join SourceForge.net's Techsay panel and you'll get the chance to share > > > > your opinions on IT & business topics through brief surveys - and earn > > > > cash > > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVD > > > >EV _______________________________________________ > > > > Amsn-devel mailing list > > > > Amsn-devel@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/amsn-devel > > > > > > ------------------------------------------------------------------------- > > > Take Surveys. Earn Cash. Influence the Future of IT > > > Join SourceForge.net's Techsay panel and you'll get the chance to share > > > your opinions on IT & business topics through brief surveys - and earn > > > cash > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > _______________________________________________ > > > Amsn-devel mailing list > > > Amsn-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/amsn-devel > > > > ------------------------------------------------------------------------- > > Take Surveys. Earn Cash. Influence the Future of IT > > Join SourceForge.net's Techsay panel and you'll get the chance to share > > your opinions on IT & business topics through brief surveys - and earn cash > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > _______________________________________________ > > Amsn-devel mailing list > > Amsn-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/amsn-devel > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Amsn-devel mailing list > Amsn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/amsn-devel ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel
