On Mon, 2006-12-18 at 10:16 -0500, Youness Alaoui wrote:
> Hello,
> First, congratulations vivia for the empty copy paste, lol
> second, about tjikkun's Q/A, wrong answer because [package require Tk] > 8.3
> means that it loads Tk, then checks
> if it's > 8.3, it doesn't mean only a Tk > 8.3 will be loaded, so Tk will
> always be loaded this way...
ah sure, i was thinking of [package require Tk 8.4]
> About the check to 8.4, it's good but I was just wondering why 8.4.13.. is it
> that 8.4.13 has the fix in Tk
> itself ?
Yes, I at least don't have any problems when i use 8.4.13
> Also, I was wondering if the bind is needed since binding to
> ::tk::TextKeySelect is the default, so no
> need to overide, right ?
Without that line it didn't work for me, so i am not sure if it is there
by default.
> and finally, I don't really like the overriding of Tk procs, I would realy
> prefer it to
> be :
> proc my_TextKeySelect { .. .} {
> if { < 8.4.13 } {
> ....
> } else {
> eval ::tk::TextKeySelect $args ..
> }
>
> what do you think?
In this case i like it
As I see it there are 2 possibilities:
1) We don't like a default behaviour of tcl/tk that we want to change,
but it will not be in default tcl/tk
- We should create our own my_* proc that does what we want
2) We find a bug (bug can be broad) in tcl/tk that is/will be fix in a
newer version
- We should overwrite the buggy proc for versions before the fix. That
way all those version related fixes are in one place! if we don't
overwrite we have to create a my_* proc and change all references
everywhere in amsn to use that and not the ::tk:: one
I hope you see my point, if you have other arguments please let me know
and i might change my opinion.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel
