Hi Square87,
Thank you for the contribution and the patch.
It's indeed a useful idea for some users, but I wonder if it's really
necessary.
Of couse, we'll need the change that logs when the user's nick is changed,
without it the feature is useless.
I would also like to have other developer's opinion over this, should it be
committed or should it become a
plugin or something ?
KKRT
On Thu, Feb 01, 2007 at 01:57:56PM +0100, square87 wrote:
> Hello.
> Yesterday i have saw an msn plus feature.
> That is the possibility to log short nicks instead of original nick.
> Msn Plus abbreviates nicks, in log conversation, to 15 letters. In my
> implementation for amsn is 10 letters.
> Anyway with this option enabled you cannot see originals nick in log
> conversation.
> So when a conversation starts there is a proc that logs first of all the
> real nicks.
> If this "feature" will be accept, I try to write a proc that logs when the
> nick is changed.
> Anyway I am not a tcl/tk programmer.
> Thanks for your attention and sorry for my English.
> Square87
> Index: gui.tcl
> ===================================================================
> --- gui.tcl (revisione 7874)
> +++ gui.tcl (copia locale)
> @@ -2504,7 +2504,12 @@
> WinWrite $chatid "$message" $type $fontformat 1 $user
>
> if {[::config::getKey keep_logs]} {
> - ::log::PutLog $chatid $nick $msg $fontformat
> + if {[::config::getKey keep_logsnick]} {
> + set shortnick [string range $nick 0 9]
> + ::log::PutLog $chatid $shortnick $msg
> $fontformat
> + } else {
> + ::log::PutLog $chatid $nick $msg
> $fontformat
> + }
> }
> }
>
> Index: config.tcl
> ===================================================================
> --- config.tcl (revisione 7874)
> +++ config.tcl (copia locale)
> @@ -39,6 +39,7 @@
> ::config::setKey save_password 0 ;# a config
> file: 0|1
>
> ::config::setKey keep_logs 1 ;#Save log
> files: 0|1
> + ::config::setKey keep_logsnick 1 ;#Save short
> nick in log files instead of normal nick: 0|1
> ::config::setKey display_event_connect 1 ;#Display when
> someone connect
> ::config::setKey display_event_disconnect 1 ;#Display when
> someone disconnect
> ::config::setKey display_event_email 1 ;#Display when a new
> E-Mail is received
> @@ -1187,6 +1188,7 @@
> ::config::setKey save_password 0
> ::config::setKey connectas $connectas
> ::config::setKey keep_logs 0
> + ::config::setKey keep_logsnick 0
> ::config::setKey log_event_connect 0
> ::config::setKey log_event_disconnect 0
> ::config::setKey log_event_email 0
> Index: preferences.tcl
> ===================================================================
> --- preferences.tcl (revisione 7874)
> +++ preferences.tcl (copia locale)
> @@ -1983,9 +1983,11 @@
> label $lfname.plog1 -image [::skin::loadPixmap prefhist]
> pack $lfname.plog1 -anchor nw -side left
> checkbutton $lfname.log -text "[trans keeplog2]" -onvalue 1 -offvalue 0
> -variable [::config::getVar keep_logs]
> + checkbutton $lfname.lognick -text "[trans keeplognick]" -onvalue 1
> -offvalue 0 -variable [::config::getVar keep_logsnick]
> checkbutton $lfname.date -text "[trans logsbydate]" -onvalue 1
> -offvalue 0 -variable [::config::getVar logsbydate]
> checkbutton $lfname.camlog -text "[trans logwebcam]" -onvalue 1
> -offvalue 0 -variable [::config::getVar webcamlogs]
> pack $lfname.log -anchor w
> + pack $lfname.lognick -anchor w
> pack $lfname.camlog -anchor w
> pack $lfname.date -anchor w
>
> Index: lang/langen
> ===================================================================
> --- lang/langen (revisione 7874)
> +++ lang/langen (copia locale)
> @@ -403,6 +403,7 @@
> justonce Just once
> keepalive Keepalive (NAT)
> keeplog2 Log all conversations to aMSN's History for future viewing
> +keeplognick Log short nicks instead of normal nick
> keeplog Keep Logs of Chats
> language Language
> language_manager Language manager
>
> Index: loging.tcl
> ===================================================================
> --- loging.tcl (revisione 7874)
> +++ loging.tcl (copia locale)
> @@ -327,7 +327,11 @@
> set fileid [LogArray $email get]
> if { $fileid != 0 } {
> if { $conf == 0 } {
> - puts -nonewline $fileid
> "\|\"LRED\[[trans lconvstarted [clock format [clock seconds] -format "%d %b
> %Y %T"]]\]\n"
> + if {[::config::getKey keep_logsnick]} {
> + puts -nonewline $fileid
> "\|\"LRED\[[trans lconvstarted [clock format [clock seconds] -format "%d %b
> %Y %T"]] \n[::abook::getPersonal MFN]\n [::abook::getDisplayNick $email]\]\n"
> + } else {
> + puts -nonewline $fileid
> "\|\"LRED\[[trans lconvstarted [clock format [clock seconds] -format "%d %b
> %Y %T"]]\]\n"
> + }
> } else {
> puts -nonewline $fileid
> "\|\"LRED\[[trans lenteredconf $email [clock format [clock seconds] -format
> "%d %b %Y %T"]] \(${users}\) \]\n"
> }
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier.
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Amsn-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/amsn-devel
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Amsn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/amsn-devel
