Ok, I committed it, you can read the diff in the amsn-commits mailing list.
I also fixed some weird unclean code, we were using $user to check if
{[::OIM_GUI::isOIM $user] } where $user is
supposed to be the nickname of a user, not his email, so I changed it to
$chatid.
But it worked before because the PutLog was called by OIM functions with
$chatid $email, instead of $chatid
$nickname
which made it work normal... but it's bad code, you shouldn't use the nickname
(var was called $nick but could
have been called $nick) where a chatid is expected (since isOIM expects a
chatid).
KKRT
On Thu, Feb 01, 2007 at 08:48:02PM -0500, Youness Alaoui wrote:
> ok, your code is wrong, but it's ok, we know you're not a programmer.
> but what if the error happens in a multi user conversation ?
> what if it happens after you closed the window ? You also added the
> fontformat argument but it's not used
> anywhere in the code...
> I'll fix it, commit and read the commit log to understand how it should have
> been done.
> thanks
>
> KKRT
>
> On Thu, Feb 01, 2007 at 06:47:52PM +0100, square87 wrote:
> > Hello.
> > Sometime sending message fails so the user don't read what we have written,
> > but the log system logs not-sending-messages, too.
> > When we read the conversation, for example, after two weeks we don't
> > remember if certain messages are sending or not.
> > So i think that this patch is useful.
> > I am not a TCL/Tk programmer.
> > Thanks for your attention and sorry for my English.
>
> > Index: loging.tcl
> > ===================================================================
> > --- loging.tcl (revisione 7874)
> > +++ loging.tcl (copia locale)
> > @@ -289,6 +289,12 @@
> > }
> > }
> >
> > + proc WriteLogForDeliveryFailed {chatid msg {fontformat ""}} {
> > + set fileid [LogArray $chatid get]
> > + if { $fileid != 0 } {
> > + puts -nonewline $fileid "\|\"LRED\[[trans deliverfail]:
> > [timestamp]: $msg\]\n"
> > + }
> > + }
> >
> >
> > #///////////////////////////////////////////////////////////////////////////////
> > # WriteLog (email txt (conf) (userlist))
> >
> > Index: gui.tcl
> > ===================================================================
> > --- gui.tcl (revisione 7874)
> > +++ gui.tcl (copia locale)
> > @@ -2401,6 +2401,9 @@
> > proc WinWriteFail {chatid msg} {
> > WinWrite $chatid "\n[timestamp] [trans deliverfail]:\n" red
> > WinWrite $chatid "$msg" gray "" 1 [::config::getKey login]
> > + if {[::config::getKey keep_logs]} {
> > + ::log::WriteLogForDeliveryFailed $chatid $msg
> > + }
> > }
> >
> >
> > #///////////////////////////////////////////////////////////////////////////////
>
> > -------------------------------------------------------------------------
> > Using Tomcat but need to do more? Need to support web services, security?
> > Get stuff done quickly with pre-integrated technology to make your job
> > easier.
> > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> > _______________________________________________
> > Amsn-devel mailing list
> > Amsn-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/amsn-devel
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier.
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Amsn-devel mailing list
> Amsn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/amsn-devel
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel
