Good!
My code is always false :)
So the solution should be logic:
When we send an OIM we are in MessageSend that calls a proc that calls a
proc... etc... that calls PutLog
Then we return in MessageSend and we have:
if {[::config::getKey keep_logs]} {
::log::PutLog $chatid $email $txt
}
So we log again and we see in log conversation:
timestamp user_login_that_we_have_sent_an_OIM: txt
So we not see our nick because in OIM::MessageSend there is:
set email $chatid
so we call (unnecessarily) PutLog with: [EMAIL PROTECTED] [EMAIL PROTECTED]
My code it's always false for this we don't call ::log::PutLog $chatid
$email $txt
So I Think that you can remove:
if {[::config::getKey keep_logs]} {
::log::PutLog $chatid $email $txt
}
I have tested without it and it works fine :)
About lconvstartedOIM, I don't know if it is correct... :P but i try:
You have started sending or receiving offline messages on $1
We may not write:
You have started sending or receiving an offline conversation
Because the user is not online (or maybe is invisible....)
Another thing I really hate this:
When I am chatting with a friend and the we add another friend we see in log
conversation:
$1 has entered into a conference on $2 {myuserlogin, friend1userlogin,
friend2userlogin}
But... the nice thing is when i am in a multichat where every minute for a
persone that leaves 2 persons are added... I see, in log conversation, this
hateful and unnecessary user_list...
The same for lprivtoconf, lconftopriv... Believe me it's very unnecessary,
because we already log when a user enters/leaves a convo
What do you think about to erase this _features_ ?
I may send you another diff with this change now (whit this OIM diff that
you are checking) or after you are checked OIM diffs.
I believe that you are not logging your conversation :)
Thanks
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel
