hello, your patch should fix it but it's not the best way to do it... here's the original line : button $w.fb.play -text [trans "winks_play"] -command "::winks::PlayWink $wink(swf)" here's your fix : button $w.fb.play -text [trans "winks_play"] -command "::winks::PlayWink \"$wink(swf)\"" here's how I would fix it : button $w.fb.play -text [trans "winks_play"] -command [list ::winks::PlayWink $wink(swf)]
it seems the original code has many of those little 'wrong standard'.. the code has never been reviewed by an amsn team member, so I'm not sure how robust it is, or how good it is.. the only thing I know about the code that is wrong, is that it uses [string first] and [split] and stuff in order to read the XML files (content.xml) instead of using the API xml2list and GetXmlEntry and GetXmlAttribute, etc.. KKRT On Mon, Mar 12, 2007 at 02:32:47PM +0100, Paller wrote: > Hi all! > > Yesterday I had run in to a bug > > ( http://amsn-project.net/forums/viewtopic.php?t=2366&start=240 ) > > wrong # args: should be "::winks::PlayWink wfile" > while executing > "::winks::PlayWink C:/Documents and > Settings/Paller.KATA/amsn/paller1984_sadamsnuser_com/winks/2af42d1c3d8ebd03573311d48d740a55/water_balloon.swf" > invoked from within > ".editWink.fb.play invoke" > ("uplevel" body line 1) > invoked from within > "uplevel #0 [list $w invoke]" > (procedure "tk::ButtonUp" line 24) > > > I didn't remember when this came from. > But today I tested it again, and found that it's came from the add new winks > menu's play button. > > here is a diff for a solution(?) for it > > [EMAIL PROTECTED]:~/amsn/plugins/winks> svn diff > Index: winks.tcl > =================================================================== > --- winks.tcl (revision 8196) > +++ winks.tcl (working copy) > @@ -645,7 +645,7 @@ > frame $w.fb > button $w.fb.del -text [trans "delete"] -command > "::winks::DeleteWink $chatid \"$sha1d\"" > button $w.fb.ok -text [trans "rename"] -command > "::winks::RenameWink $chatid \"$sha1d\"" > - button $w.fb.play -text [trans "winks_play"] > -command "::winks::PlayWink $wink(swf)" > + button $w.fb.play -text [trans "winks_play"] > -command "::winks::PlayWink \"$wink(swf)\"" > button $w.fb.cancel -text [trans cancel] -command > "destroy $w" > bind $w <<Escape>> "destroy $w" > Index: winks.tcl > =================================================================== > --- winks.tcl (revision 8196) > +++ winks.tcl (working copy) > @@ -645,7 +645,7 @@ > frame $w.fb > button $w.fb.del -text [trans "delete"] -command > "::winks::DeleteWink $chatid \"$sha1d\"" > button $w.fb.ok -text [trans "rename"] -command > "::winks::RenameWink $chatid \"$sha1d\"" > - button $w.fb.play -text [trans "winks_play"] -command > "::winks::PlayWink $wink(swf)" > + button $w.fb.play -text [trans "winks_play"] -command > "::winks::PlayWink \"$wink(swf)\"" > button $w.fb.cancel -text [trans cancel] -command > "destroy $w" > bind $w <<Escape>> "destroy $w" > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys-and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Amsn-devel mailing list > Amsn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/amsn-devel ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel
