El jue, 15-03-2007 a las 01:41 -0400, Youness Alaoui escribió:
> first, thanks Gabriel for yet another interesting patch!
My pleasure :)
> first, I'll start with the 'philosophical' par of the questiont.. I don't
> like that much the use of a
> combobox and have the user set it to get the behavior.. I see two options :
> 1 - always show all the users, as it's done now with your patch when the
> checkbox is enabled
> 2 - at the end of the list of users, add a separator (a text with
> "-----------" or something) and add
> underneath it all the users who have a log and aren't on your list...
I also like option 1, as does Karel, the only other person to comment on
this. I did the combobox stuff because I didn't feel comfortable
replacing an existing behavior with a behavior I personally like without
asking first, but if everyone seems to agree, I'll just put the "all
users" as the new behavior. Expect a new patch soon.
> now, let's do the 'technical' part.. here's the code review I'd give you :
Thanks a lot for your very detailed review, I appreciate it.
--Gabriel
________________________________________________________________________
Gabriel Gambetta
Mystery Studio - http://www.mysterystudio.com
Misc stuff - http://www.mysterystudio.com/gabriel
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel
