2007/9/6, Youness Alaoui <[EMAIL PROTECTED]>:
>
> Hi,
> I'll look at this later, when I get time. Thanks for sending the patches.
> About the resize to original, it's there for a reason, you sometimes need
> to resize to 'original', also
> 'original' means by definition, that it would need to fetch it again.
> Think about this.. a user has his DP's original size set to 150x150.. you
> do a set to original, with
> your patch, it gets resized to 96x96, which is wrong..


No it's not wrong :P I did just think that if autoresizedp is enabled when
we do "set to original" it was the same thing of "set to default" :P. I did
think in this way because it's the actual behaviour, but for others
"reasons" :P. But it's simple to "fix" it.

Also, I sometimes use the 'original' when I want it to redownload.. try for
> example setting to huge,
> then small, then huge, then small, then 'normal'.. what do you see ? very
> very bad image quality, which
> is why you do 'original', to get back that image quality you lost...



Yes i know about that... but we already have it in our hard disk so maybe we
can do that:
In getDisplayPicture (see my last diff)
Instead of:

         if {$opz == 2} {
             if {[::config::getKey autoresizedp]} {
                 ::picture::Resize $picName 96 96
             }
             return $picName
         }

we can use:

        if {$opz == 2} {
            image delete $picName
            image create photo $picName -file "$file" -format cximage
            return $picName
        }

and in ConvertDPSize
instead of:
    ::picture::Resize [getDisplayPicture $user 0] $width $height
we can use:
    ::picture::Resize [getDisplayPicture $user 1 2] $width $height

In this way every time we want to change size of a DP we work on original DP
and not on a resiezed_resized_..._DP

It's just an idea.
Thanks, bye
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel

Reply via email to