On Thu, Aug 7, 2008 at 4:04 PM, Ubitux <[EMAIL PROTECTED]> wrote:
> Hi there,
>
> Don't you think the offline contacts should appear in the contact ->
> delete window ? I do not agree with the actual thing, so I made a
> simple patch to add offline contacts in that list :

I agree with this..
>
> But now, I think that when offline contacts are displayed, there is no
> need to display the "Others" button, so I decide to do not display it
> when $show_offline is set to 1. I tried to see in which case I could
> have wrong, and I don't find it but I've certainly made a mistake. If
> it's not the case, here is the little patch :
>
> @@ -2646,7 +2646,13 @@
>                if {$show_nonim} {
>                        lappend userlist [list "[::abook::getDisplayNick 
> $user_login]
> ($user_login)" $user_login]
>                }
> -               ::amsn::listChoose $title $userlist $command 1 1
> +
> +               if {$show_offlines} {
> +                       set disp_others 0
> +               } else {
> +                       set disp_others 1
> +               }
> +               ::amsn::listChoose $title $userlist $command $disp_others 1
>        }

But I think this will remove the "other" button for "send email" too,
which is not a good thing (you might want to manually enter the email
address), so I won't apply this part of the patch...

> Another thing : I didn't understood the meaning of the "nonim" option
> in that procedure, and same with the option "skip" of
> ::amsn::listChoose (the "1" in the last line), so I may have did
> something wrong in that patch, so if someone can check it...

I guess nonim is meant to show users not in Contant List, but in your
MSN address book. However, I don't think it works. I might be wrong.
Anyone can help here?


I'm applying the first part of the patch (show all contacts when
deleting). Thanks very much!

-- 
(:===========================================:)
 Alvaro J. Iradier Muro - [EMAIL PROTECTED]

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel

Reply via email to