On Fri, Jul 3, 2020 at 2:07 PM Hans de Goede <hdego...@redhat.com> wrote:
> Hi, > > On 6/30/20 6:59 PM, Brian C. Lane wrote: > > On Tue, Jun 30, 2020 at 01:53:19PM +0200, Hans de Goede wrote: > >> So 2 questions: > >> > >> 1. What do you think of my proposal to disable these > >> services (when not needed) in the livecd post-install > >> config phase? Would you be willing to accept a > >> merge-req for this? > >> > >> 2. Its been a long time since I last touched the > >> anaconda code, my python is quite rusty and my > >> plate is way too full, so I was wondering if one > >> of you could implement this if we chose to go this > >> route? > > > > I think implementing this may be even easier. Anaconda runs post-script > > snippets from /usr/share/anaconda/post-scripts/*ks at the end of every > > install. The livecd could drop in a script to handle disabling these, I > > think. > > > > Current scripts are here: > > > > https://github.com/rhinstaller/anaconda/tree/master/data/post-scripts > > Yes that would be an option, although getting the list of pkgs > which are deemed as being necessary for the configured storage > (and thus should not have their services disabled) might be > tricky to do from such a post-install script ? > > Anyways, going by Vojtěch's reply, there are no objections to > removing device-mapper-multipath from the livecd. And it will be > quite easy to make the dmraid-activation service disable itself > if no dmraid sets are found (it already is a shell script). > > So I believe it would be best to move forward with this as > I original proposed in the 2 change pages: > > https://fedoraproject.org/wiki/Changes/DisableDmraidOnFirstRun > > https://fedoraproject.org/wiki/Changes/RemoveDeviceMapperMultipathFromWorkstationLiveCD > > This requires almost no anaconda changes as mentioned in another > part of the thread, the hard-dep on device-mapper-multipath needs > to be dropped. But with some luck that is all that is required > on the anaconda side. > > The anaconda's dependency on device-mapper-multipath is caused by fcoe-utils: anaconda -> anaconda-install-env-deps -> fcoe-utils -> device-mapper-multipath Is it expected that the support for FCoE devices will be dropped from Live OS? If yes, it shouldn't be a problem to change the dependency on fcoe-utils to weak. Vendy Regards, > > Hans > > _______________________________________________ > Anaconda-devel-list mailing list > Anaconda-devel-list@redhat.com > https://www.redhat.com/mailman/listinfo/anaconda-devel-list
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/anaconda-devel-list
