I apologize for the delay moderating the ML, but the patch has already been posted a while ago: https://github.com/rhinstaller/anaconda/pull/3669 Thank you!
On Mon, Nov 8, 2021 at 3:00 PM Patrick Riehecky <[email protected]> wrote: > Can you submit this patch at > https://github.com/rhinstaller/anaconda/pulls > > On Wed, 2021-10-27 at 01:16 -0600, Qi Yong wrote: > > bug fix: activate connection from callback _connection_updated_cb > > > > this is the correct order > > ui.tui.spokes.network: updating connection ... > > ui.tui.spokes.network: updated connection ... > > ui.tui.spokes.network: activating connection ... > > > > otherwise it could be wrong as > > ui.tui.spokes.network: updating connection ... > > ui.tui.spokes.network: activating connection ... > > ui.tui.spokes.network: updated connection ... > > > > diff --git a/pyanaconda/ui/tui/spokes/network.py > > b/pyanaconda/ui/tui/spokes/network.py > > index 903a1ba61..f80e72d0b 100644 > > --- a/pyanaconda/ui/tui/spokes/network.py > > +++ b/pyanaconda/ui/tui/spokes/network.py > > @@ -404,10 +404,6 @@ class NetworkSpoke(FirstbootSpokeMixIn, > > NormalTUISpoke): > > > > if new_spoke.apply_configuration: > > self._apply = True > > - device = self.nm_client.get_device_by_iface(iface) > > - log.debug("activating connection %s with device %s", > > - connection_uuid, iface) > > - self.nm_client.activate_connection_async(connection, > > device, None, None) > > > > self._network_module.LogConfigurationState( > > "Settings of {} updated in TUI.".format(iface) > > @@ -608,6 +604,12 @@ class ConfigureDeviceSpoke(NormalTUISpoke): > > connection.update2_finish(result) > > log.debug("updated connection %s:\n%s", connection_uuid, > > > > connection.to_dbus(NM.ConnectionSerializationFlags.ALL)) > > + if self.apply_configuration: > > + nm_client = network.get_nm_client() > > + device = nm_client.get_device_by_iface(self._iface) > > + log.debug("activating connection %s with device %s", > > + connection_uuid, self._iface) > > + nm_client.activate_connection_async(connection, device, > > None, None) > > > > > > def get_default_connection(iface, device_type): > > > > > _______________________________________________ > Anaconda-devel-list mailing list > [email protected] > https://listman.redhat.com/mailman/listinfo/anaconda-devel-list
_______________________________________________ Anaconda-devel-list mailing list [email protected] https://listman.redhat.com/mailman/listinfo/anaconda-devel-list
