I notice in art/build/art.go, ART_READ_BARRIER_TYPE can be set to BROOKS. 
Once I made the change and build, compiler gives me error about noreturn of 
function mirror::Object::SetReadBarrierState, I have to change the 
declaration from 


#ifndef USE_BAKER_OR_BROOKS_READ_BARRIER
  NO_RETURN
#endif
  ALWAYS_INLINE void SetReadBarrierState(uint32_t rb_state) 
REQUIRES_SHARED(Locks::mutator_lock_);

to


#ifndef USE_BAKER_READ_BARRIER
  NO_RETURN
#endif
  ALWAYS_INLINE void SetReadBarrierState(uint32_t rb_state) 
REQUIRES_SHARED(Locks::mutator_lock_);




Then compiler gives me another error:


art/runtime/gc/collector/concurrent_copying.cc:2311:3: error: static_assert 
failed "Object header size does not match"
  static_assert(kObjectHeaderSize == 
sizeof(mirror::HeapReference<mirror::Class>) +
  ^             
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.







Is BROOKS barrier type still supported?




-- 
-- 
You received this message because you are subscribed to the "Android Building" 
mailing list.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
"Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/android-building/ba5ae1dc-0617-4dc3-8388-ec9ed12862e6%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to