We've recently updated our documentation around conditionals (and most use of make variables fall into the same category):
https://android.googlesource.com/platform/build/soong/+/master/README.md#how-do-i-write-conditionals tl;dr: we'd prefer you didn't use them, but if you need to, you can via a Go plugin. - Dan On Fri, Nov 22, 2019, 7:11 AM Chih-Wei Huang <cwhu...@android-x86.org> wrote: > I have the same question. > I'd like to use product variables like TARGET_PRODUCT in Android.bp. > I searched the whole AOSP tree but still can't find a way to do that. > Sigh,,, Is it possible? > > DavidRobin於 2019年7月16日星期二 UTC+8下午11時13分22秒寫道： >> >> Thanks for your reply. >> Our purpose is to generate "License checking code" for specific product >> build. >> So we have a shell script to generate the code based on the PRODUCT_XXX >> properties. >> >> Are you implying that Android.bp should only be used in generic (product >> independent) modules? >> And this kind of code should be put in device/product specific stuff and >> use Android.mk to achieve the goal? >> (P.S. will Android.mk be kept or will Android.bp take over the whole >> build?) >> >> On Tuesday, July 16, 2019 at 2:13:13 AM UTC+8, Dan Willemsen wrote: >>> >>> Those variables aren't exposed, partially because it becomes very >>> difficult to understand which pieces of the system are then >>> product-specific vs generic. Is there a reason why you wouldn't just read >>> the runtime properties rather than trying to embed those values in code? >>> >>> - Dan >>> >>> On Mon, Jul 15, 2019 at 9:31 AM DavidRobin <huangw...@gmail.com> wrote: >>> >>>> I saw that in external/libmojo/Android.bp there is an example to >>>> generate header files for later build process. >>>> >>>> genrule { >>>> name: "libmojo_mojom_headers", >>>> cmd: "$(location mojom_source_generator_sh)" + >>>> " --mojom_bindings_generator=$(location >>>> mojom_bindings_generator)" + >>>> " --package=external/libmojo" + >>>> " --output_dir=$(genDir)" + >>>> " --bytecode_path=$(genDir)" + >>>> " --typemap=$(location >>>> gen/mojo/common/common_custom_types__type_mappings)" + >>>> " --generators=c++" + >>>> " --use_new_wrapper_types" + >>>> " $(in)", >>>> >>>> However, I cannot find how to use vars like $(PRODUCT_BRAND) >>>> $(PRODUCT_MANUFACTURER) etc in this cmd line. >>>> Please help. >>>> Thanks. >>>> >>> -- > -- > You received this message because you are subscribed to the "Android > Building" mailing list. > To post to this group, send email to android-building@googlegroups.com > To unsubscribe from this group, send email to > android-building+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/android-building?hl=en > > --- > You received this message because you are subscribed to the Google Groups > "Android Building" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to android-building+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/android-building/6a64020b-1413-4723-aabe-3d6ce27f3ae9%40googlegroups.com > <https://groups.google.com/d/msgid/android-building/6a64020b-1413-4723-aabe-3d6ce27f3ae9%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- You received this message because you are subscribed to the "Android Building" mailing list. To post to this group, send email to android-building@googlegroups.com To unsubscribe from this group, send email to android-building+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/android-building?hl=en --- You received this message because you are subscribed to the Google Groups "Android Building" group. To unsubscribe from this group and stop receiving emails from it, send an email to android-building+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/android-building/CALQgHdnnDnFR31OzHoFh22CPTiF4L7vtr0JqHdJuCUNAMiSn1Q%40mail.gmail.com.
