PVMF3FF_DEFAULT_NUM_OF_FRAMES does determine how many frames can be read from an mp3 file. However, one needs to be careful in increasing/ decreasing this number. If we increase this value by too much, we would risk starving the decoder node for a longer duration of time. Please note that the same piece of code is exercised during HTTP streaming of mp3 clips. Here also, the data from the source node might not be readily available, and we might end up sending the source node into a constant state of auto-pause/auto-resume.
There is no theoretically optimal value that one can come up with that will satisfy all needs. :-( So, you would have to experiment with your codec to see if it serves your purpose. fyi, PVMF3FF_DEFAULT_NUM_OF_FRAMES has been increased to 5 in OpenCORE 2.0 release. -Ravi On Feb 3, 1:17 am, mahamannu <[email protected]> wrote: > Hi, > > Currently PV Opencore Framework provides 2 Frames of 4K MP3 parsed > bytes each as one input buffer sample to be decoded by OMX. Moving to > H/W decoders and better optimization in general, we can potentially > push in multiple frames as part of one OMX input buffer of size 40 K. > > Going through the pvmf_mp3ffparser_node.cpp code it appears Changing > the following #define from 2 to higher would be sufficient ? > //Maximum number of mp3 frames to be read at a time > uint32 numsamples = PVMF3FF_DEFAULT_NUM_OF_FRAMES; > > Is this as simple as this, or am I missing something ? > cheers, M --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "android-framework" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/android-framework?hl=en -~----------~----~----~----~------~----~------~--~---
