On 18 March 2010 20:33, Chris Stratton <[email protected]> wrote: > I dont think the usb drivers are complete enough to be unloadable. Andrew > de Quincey was doing some preliminary work in that area to permit switching > to usb host mode, also someone observed that the samsung galaxy msm 7201a > usb drivers seem more mature than the parent android ones for the same chip. > > On Mar 18, 2010 4:26 PM, "Sudheesh J" <[email protected]> wrote: > > In the android gadget code I see the following platform driver > registration: > In mass_storage_bind_config: > >> rc = platform_driver_register(&fsg_platform_driver); > > I don't see this getting cleaned up on module exit. Shouldn't this be > unregistered on fsg_function_unbind or somwhere? > Or am I missing something?
Hi, yeah, the function driver code as it stands is not unloadable; if you look at the last patch I posted for the hero usb support, I had to do a fairly large amount of work to make them clean up properly, and add proper error detection. I'd be happy to split the patch up if requested and there was a likelihood of getting it into the android tree, but I've had no communication from Google about it. I don't see the point if not as it would complicate things having multiple patches to apply. The codeaurora code is better in places, but further investigation shows its still lacking a fair amount of cleanup code. Practically, its perhaps not so necessary given that it has full USB OTG support, but from a correctness point of view, it does annoy me :) -- unsubscribe: [email protected] website: http://groups.google.com/group/android-kernel To unsubscribe from this group, send email to android-kernel+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
