It's certainly an idea which crossed my mind for this one line patch. 
Unfortunately we have a few other patches which are slightly larger and 
definitely wouldn't make it in to the mainline (one resizes the status bar to 
put home, back, and menu buttons in it).

Al.
--

* Looking for Android Apps? - Try http://andappstore.com/ *

======
Funky Android Limited is registered in England & Wales with the company number  
6741909. 

The views expressed in this email are those of the author and not necessarily 
those of Funky Android Limited, it's associates, or it's subsidiaries.

On 22 Aug 2010, at 00:34, Naseer Ahmed wrote:

> For your particular case, I think you're better off adding a new parameter to 
> frameworks/base/core/res/res/values/config.xml, then reading that in the 
> policy.
> You could then submit this as a patch to the android mainline and if it gets 
> accepted, you can then use a normal resource overlay for config.xml
> 
> 
> 
> 
> 
> On Sat, Aug 21, 2010 at 5:03 PM, Al Sutton <[email protected]> wrote:
> [copied to list]
> 
> I'm a fan of the KISS principal, so if I can reduce the number of 
> repositories involved then I tend to head that way.
> 
> One of the patches we have to make is a single line change to a two files (we 
> could do it in one, but it's for frameworks/policies/base so we do it in both 
> the mid and phone profiles). Unfortunately, we have to fork and maintain a 
> whole repository for the project just because of the one line change, and 
> that, to me, seems like a lot of overhead (you can see the patch at 
> http://www.gitorious.org/openaos-testing/frameworks_policies_base/commit/51dcc06ce534fee03dd356e788535ba17c7f39e5)
> 
> If that's the way it needs to be done, then that's the way it needs to be 
> done, but it would make things simpler from an admin and maintenance point of 
> view if everyone on the OpenAOS project could use the "standard" repo and 
> have the one line patch applied.
> 
> 
> Al.
> --
> 
> * Looking for Android Apps? - Try http://andappstore.com/ *
> 
> ======
> Funky Android Limited is registered in England & Wales with the company 
> number  6741909. 
> 
> The views expressed in this email are those of the author and not necessarily 
> those of Funky Android Limited, it's associates, or it's subsidiaries.
> 
> On 21 Aug 2010, at 11:11, Magnus Bäck wrote:
> 
>> On Saturday, August 21, 2010 at 09:51 CEST,
>>     Al Sutton <[email protected]> wrote:
>> 
>>> We've ended up with a forked repository at the moment. The main
>>> problem with post checkout patching (or file copying) is that repo
>>> will then refuse to update the files due to detecting local changes.
>> 
>> Easily fixed with git stash.
>> 
>>> The ideal system would allow us to continue to use repo to keep the
>>> checked out tree up to date and apply the required changes during a
>>> build so we can keep all our changes in the vendor/xxx tree. Is that
>>> possible with the current build system?
>> 
>> Don't fight the system. You are de facto branching the git in question,
>> so use the facilities for branching that Repo and Git provide. If it's
>> just your personal changes you can simply commit them on a topic branch
>> and Repo will automatically rebase it for you each time you sync. If
>> it's a shared branch you probably want to set up a manifest branch where
>> you change the `revision' attribut to point to the shared branch. You
>> could also use a local manifest to accomplish the same thing. It's hard
>> to be more specific without details about your environment.
>> 
>> -- 
>> Magnus Bäck                      Opinions are my own and do not necessarily
>> SW Configuration Manager         represent the ones of my employer, etc.
>> Sony Ericsson
>> 
>> -- 
>> unsubscribe: [email protected]
>> website: http://groups.google.com/group/android-porting
> 
> 
> -- 
> unsubscribe: [email protected]
> website: http://groups.google.com/group/android-porting
> 

-- 
unsubscribe: [email protected]
website: http://groups.google.com/group/android-porting

Reply via email to