what Chad means is
>> StringUtils.capitalize(((Attribute)metaObject).getName());
should be
>> StringUtils.capitalize(getName());
using the inheritance of the facades is not only more elegant but also
allows us to keep a strict separation between metafacades interfaces and
implementations (on a specification level, uml -> uml14, uml20)
-- Wouter
> Sasha,
>
> You should not be using the meta model directly from a cartridge, you need
> to use the base metafacade model (this keeps the cartridges insulated
> from
> changes in the meta models when we support more than UML 1.4. Also can
> you
> please keep the coding style to use the ending brace on each line (to be
> consistent with the rest of the code base)?
>
> Thanks,
>
> Chad
>
>
>
> ----- Original Message -----
> From: "Sascha-Matthias Kulawik" <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Sent: Tuesday, October 12, 2004 7:00 AM
> Subject: [Andromda-cvs] CVS update:
> samples/car-rental-system/hibernate/ejb
> .cvsignore
>
>
>> User: skulawik
>> Date: 04/10/12 06:00:25
>>
>> Modified: andromda-ejb project.xml
>> andromda-ejb/src/test/expected cartridge-output.zip
>>
>> andromda-ejb/src/java/org/andromda/cartridges/ejb/metafacades
>> EJBEntityAttributeFacadeLogicImpl.java
>> Added: animal-quiz/hibernate/sar .cvsignore
>> car-rental-system/hibernate/sar .cvsignore
>> andromda-spring .cvsignore
>> etc/web/taglibs/formatting .cvsignore
>> animal-quiz/hibernate/ejb .cvsignore
>> car-rental-system/hibernate/ejb .cvsignore
>> Log:
>> Fixed the "is"-getter problem with ejb cartridge
>>
>> Revision Changes Path
>> 1.6 +0 -0 samples/animal-quiz/hibernate/sar/.cvsignore
>>
>>
>>
>>
>> 1.6 +0 -0 samples/car-rental-system/hibernate/sar/.cvsignore
>>
>>
>>
>>
>> 1.1 cartridges/andromda-spring/.cvsignore
>>
>> Index: .cvsignore
>> ===================================================================
>> target
>> *.log
>>
>>
>>
>> 1.20 +10 -0 cartridges/andromda-ejb/project.xml
>>
>> Index: project.xml
>> ===================================================================
>> RCS file: /cvsroot/andromda/cartridges/andromda-ejb/project.xml,v
>> retrieving revision 1.19
>> retrieving revision 1.20
>> diff -u -w -r1.19 -r1.20
>> --- project.xml 10 Sep 2004 08:20:22 -0000 1.19
>> +++ project.xml 12 Oct 2004 13:00:22 -0000 1.20
>> @@ -73,6 +73,16 @@
>> <version>${pom.currentVersion}</version>
>> </dependency>
>> <dependency>
>> + <groupId>jmi</groupId>
>> + <artifactId>jmiuml</artifactId>
>> + <version>1.4di</version>
>> + </dependency>
>> + <dependency>
>> + <groupId>jmi</groupId>
>> + <artifactId>jmi</artifactId>
>> + <version>20030918</version>
>> + </dependency>
>> + <dependency>
>> <groupId>commons-lang</groupId>
>> <artifactId>commons-lang</artifactId>
>> <version>2.0</version>
>>
>>
>>
>> 1.8 +51 -41
>> cartridges/andromda-ejb/src/test/expected/cartridge-output.zip
>>
>> <<Binary file>>
>>
>>
>> 1.1 productbuild/etc/web/taglibs/formatting/.cvsignore
>>
>> Index: .cvsignore
>> ===================================================================
>> target
>>
>>
>>
>> 1.2 +18 -20
>> cartridges/andromda-ejb/src/java/org/andromda/cartridges/ejb/metafacades/EJBEntityAttributeFacadeLogicImpl.java
>>
>> Index: EJBEntityAttributeFacadeLogicImpl.java
>> ===================================================================
>> RCS file:
>> /cvsroot/andromda/cartridges/andromda-ejb/src/java/org/andromda/cartridges/ejb/metafacades/EJBEntityAttributeFacadeLogicImpl.java,v
>> retrieving revision 1.1
>> retrieving revision 1.2
>> diff -u -w -r1.1 -r1.2
>> --- EJBEntityAttributeFacadeLogicImpl.java 7 Aug 2004 18:40:35 -0000
>> 1.1
>> +++ EJBEntityAttributeFacadeLogicImpl.java 12 Oct 2004 13:00:24 -0000
>> 1.2
>> @@ -1,6 +1,8 @@
>> package org.andromda.cartridges.ejb.metafacades;
>>
>> import org.andromda.cartridges.ejb.EJBProfile;
>> +import org.apache.commons.lang.StringUtils;
>> +import org.omg.uml.foundation.core.Attribute;
>>
>> /**
>> * MetafacadeLogic implementation for
>> @@ -8,26 +10,22 @@
>> *
>> * @see
>> org.andromda.cartridges.ejb.metafacades.EJBEntityAttributeFacade
>> */
>> -public class EJBEntityAttributeFacadeLogicImpl
>> - extends EJBEntityAttributeFacadeLogic
>> - implements
>> org.andromda.cartridges.ejb.metafacades.EJBEntityAttributeFacade
>> -{
>> +public class EJBEntityAttributeFacadeLogicImpl extends
>> EJBEntityAttributeFacadeLogic implements
>> + org.andromda.cartridges.ejb.metafacades.EJBEntityAttributeFacade {
>> // ---------------- constructor -------------------------------
>>
>> - public EJBEntityAttributeFacadeLogicImpl(
>> - Object metaObject,
>> - String context)
>> - {
>> + public EJBEntityAttributeFacadeLogicImpl(Object metaObject, String
>> context) {
>> super(metaObject, context);
>> }
>>
>> /**
>> * @see
>> org.andromda.cartridges.ejb.metafacades.EJBEntityAttributeFacade#getTransactionType()
>> */
>> - public java.lang.String handleGetTransactionType()
>> - {
>> - return (String)this.findTaggedValue(
>> - EJBProfile.TAGGEDVALUE_EJB_TRANSACTION_TYPE,
>> - true);
>> + public java.lang.String handleGetTransactionType() {
>> + return (String)
>> this.findTaggedValue(EJBProfile.TAGGEDVALUE_EJB_TRANSACTION_TYPE, true);
>> + }
>> +
>> + public java.lang.String getGetterName() {
>> + return "get" +
>> StringUtils.capitalize(((Attribute)metaObject).getName());
>> }
>> }
>> \ No newline at end of file
>>
>>
>>
>> 1.6 +0 -0 samples/animal-quiz/hibernate/ejb/.cvsignore
>>
>>
>>
>>
>> 1.6 +0 -0 samples/car-rental-system/hibernate/ejb/.cvsignore
>>
>>
>>
>>
>>
>>
>> -------------------------------------------------------
>> This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
>> Use IT products in your business? Tell us what you think of them. Give
>> us
>> Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out
>> more
>> http://productguide.itmanagersjournal.com/guidepromo.tmpl
>> _______________________________________________
>> Andromda-cvs mailing list
>> [EMAIL PROTECTED]
>> https://lists.sourceforge.net/lists/listinfo/andromda-cvs
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
> Use IT products in your business? Tell us what you think of them. Give us
> Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out
> more
> http://productguide.itmanagersjournal.com/guidepromo.tmpl
> _______________________________________________
> Andromda-devel mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/andromda-devel
>
--
Wouter
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Andromda-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/andromda-devel
