[ 
http://thecla.homeftp.net:8380/jira/browse/HIB-20?page=comments#action_11053 ]
     
Peter Wyngaard commented on HIB-20:
-----------------------------------

Carlos --

Great work on this.  I was able to integrate the new code into my build 
framework, update my model, and get things working!  Here are a few issues I 
had:

* Why are some tags put on the source end, and others on the destination end?

My opinion is that the *.collection.* tags should go on the many end of the 
association.


* .index and .orderByColumns tag values should be model names, not database 
names

I expected to put the model name in this tagged value (e.g., 'displayOrder') 
rather than the database column name (e.g., 'DISPLAY_ORDER').  Perhaps that's 
your thinking too, and this first pass was the quick-n-dirty version.


* add a '/' to close the <index> element in hibernate.hbm.xml.vm

This is a small bug (the only one I encountered!).  It's at line 60 in 
hibernate.hbm.xml.vm.  I made it look like this:

<index column="$sourceEnd.collectionIndexName"#if($sourceEnd.map) 
type="java.util.String"#end/>



> Set and Lists
> -------------
>
>          Key: HIB-20
>          URL: http://thecla.homeftp.net:8380/jira/browse/HIB-20
>      Project: Hibernate Cartridge
>         Type: New Feature
>     Reporter: Carlos Cuenca
>     Assignee: Carlos Cuenca
>  Attachments: cartridge-hibernate-patch.txt
>
>
> Create set and lists depending on wheter the relation End is ordered or not.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://thecla.homeftp.net:8380/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Andromda-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/andromda-devel

Reply via email to